[ 
https://issues.apache.org/jira/browse/SCB-315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343445#comment-16343445
 ] 

ASF GitHub Bot commented on SCB-315:
------------------------------------

WillemJiang commented on a change in pull request #538: SCB-315 add common 
AddressResover configuration to foundation-vertx, and use it in 
service-registry and config-cc to support dynamic config by user
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/538#discussion_r164455177
 
 

 ##########
 File path: 
foundations/foundation-vertx/src/test/java/org/apache/servicecomb/foundation/vertx/TestAddressResoverConfig.java
 ##########
 @@ -40,8 +61,7 @@ public void testGetResover() {
     ArchaiusUtils.setProperty("addressResolver.ndots", 3);
     ArchaiusUtils.setProperty("addressResolver.rotateServers", true);
     AddressResolverOptions aroc = 
AddressResolverConfig.getAddressResover("test");
-    Assert.assertEquals(2, aroc.getServers().size());
-    Assert.assertEquals("8.8.8.8", aroc.getServers().get(0));
+    Assert.assertThat(aroc.getServers(), is(Arrays.asList("8.8.8.8", 
"8.8.4.4")));
     Assert.assertEquals("test.svc.local.cluster", 
aroc.getSearchDomains().get(0));
     AddressResolverOptions aroc1 = 
AddressResolverConfig.getAddressResover("test1");
     Assert.assertEquals("default.svc.local.cluster", 
aroc1.getSearchDomains().get(0));
 
 Review comment:
   Please use assertThat here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> As a SDK user, i want to custom netty dns resovl properties so that the 
> ServiceComb has to add config support
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: SCB-315
>                 URL: https://issues.apache.org/jira/browse/SCB-315
>             Project: Apache ServiceComb
>          Issue Type: New Feature
>          Components: Java-Chassis
>    Affects Versions: java-chassis-1.0.0-m1
>            Reporter: jeho0815
>            Assignee: jeho0815
>            Priority: Major
>
> Default DNS resovl use the machine config, but sometimes the application want 
> to set by themselves to adapt to diffrent local or cloud enviroments



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to