[
https://issues.apache.org/jira/browse/SCB-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347868#comment-16347868
]
ASF GitHub Bot commented on SCB-322:
------------------------------------
liubao68 commented on a change in pull request #542: [SCB-322] merge config
center modification
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/542#discussion_r165239730
##########
File path:
dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterConfig.java
##########
@@ -110,6 +121,26 @@ public int getFirstRefreshInterval() {
return finalConfig.getInt(FIRST_REFRESH_INTERVAL,
DEFAULT_FIRST_REFRESH_INTERVAL);
}
+ public Boolean isProxyEnable() {
+ return finalConfig.getBoolean(PROXY_ENABLE, false);
+ }
+
+ public String getProxyHost() {
+ return finalConfig.getString(PROXY_HOST, "127.0.0.1");
+ }
+
+ public int getProxyPort() {
+ return finalConfig.getInt(PROXY_PORT, 8080);
+ }
+
+ public String getProxyUsername() {
+ return finalConfig.getString(PROXY_USERNAME, "user");
Review comment:
It's better to use an empty user and password when not there
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Merge config center modification
> --------------------------------
>
> Key: SCB-322
> URL: https://issues.apache.org/jira/browse/SCB-322
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
> Reporter: YaoHaishi
> Assignee: YaoHaishi
> Priority: Major
>
> merge modification of config center client from commercial edition to open
> source edition
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
