[ 
https://issues.apache.org/jira/browse/SCB-315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351192#comment-16351192
 ] 

ASF GitHub Bot commented on SCB-315:
------------------------------------

wujimin commented on a change in pull request #546: SCB-315 Config Center 
module can't get config by DynamicPropertyFacto…
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/546#discussion_r165800125
 
 

 ##########
 File path: 
foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/AddressResolverConfig.java
 ##########
 @@ -95,33 +127,55 @@ public static AddressResolverOptions 
getAddressResover(String tag) {
     }
   }
 
-  private static int getIntProperty(int defaultValue, String... keys) {
+  private static int getIntProperty(ConcurrentCompositeConfiguration 
configSource, int defaultValue, String... keys) {
 
 Review comment:
   we can make the logics simpler

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> As a SDK user, i want to custom netty dns resovl properties so that the 
> ServiceComb has to add config support
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: SCB-315
>                 URL: https://issues.apache.org/jira/browse/SCB-315
>             Project: Apache ServiceComb
>          Issue Type: New Feature
>          Components: Java-Chassis
>    Affects Versions: java-chassis-1.0.0-m1
>            Reporter: jeho0815
>            Assignee: jeho0815
>            Priority: Major
>
> Default DNS resovl use the machine config, but sometimes the application want 
> to set by themselves to adapt to diffrent local or cloud enviroments



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to