[ 
https://issues.apache.org/jira/browse/SCB-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356621#comment-16356621
 ] 

ASF GitHub Bot commented on SCB-336:
------------------------------------

codecov-io commented on issue #279: SCB-336 1.add ut about find instance with 
tag 2.optimize find api
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/279#issuecomment-364032781
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279?src=pr&el=h1)
 Report
   > Merging 
[#279](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/268cba27f2ee6ff533ea94de12833c3052b1206d?src=pr&el=desc)
 will **decrease** coverage by `0.04%`.
   > The diff coverage is `96%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279/graphs/tree.svg?src=pr&token=GAaF7zrg8R&width=650&height=150)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #279      +/-   ##
   ==========================================
   - Coverage   70.39%   70.34%   -0.05%     
   ==========================================
     Files          17       17              
     Lines        3418     3416       -2     
   ==========================================
   - Hits         2406     2403       -3     
     Misses        846      846              
   - Partials      166      167       +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[server/service/util/rule\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9ydWxlX3V0aWwuZ28=)
 | `68.24% <100%> (-0.22%)` | :arrow_down: |
   | 
[server/service/instances.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VzLmdv)
 | `71.07% <66.66%> (-0.05%)` | :arrow_down: |
   | 
[server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv)
 | `75.43% <0%> (-0.59%)` | :arrow_down: |
   | 
[server/service/util/dependency.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5Lmdv)
 | `57.58% <0%> (-0.17%)` | :arrow_down: |
   | 
[server/service/rule.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvcnVsZS5nbw==)
 | `77.25% <0%> (+0.42%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279?src=pr&el=footer).
 Last update 
[268cba2...7b7d403](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Can not filter instances with service tags
> ------------------------------------------
>
>                 Key: SCB-336
>                 URL: https://issues.apache.org/jira/browse/SCB-336
>             Project: Apache ServiceComb
>          Issue Type: Bug
>          Components: Service-Center
>            Reporter: little-cui
>            Assignee: little-cui
>            Priority: Major
>             Fix For: service-center-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to