[
https://issues.apache.org/jira/browse/SCB-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16357775#comment-16357775
]
ASF GitHub Bot commented on SCB-331:
------------------------------------
wujimin commented on a change in pull request #551: [SCB-331] log optimization
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/551#discussion_r167114260
##########
File path:
foundations/foundation-config/src/main/java/org/apache/servicecomb/config/ConfigUtil.java
##########
@@ -151,7 +151,7 @@ private static void
duplicateServiceCombConfigToCse(ConcurrentCompositeConfigura
public static DynamicWatchedConfiguration
createConfigFromConfigCenter(Configuration localConfiguration) {
if (localConfiguration.getProperty(configCenterUrlKey) == null) {
- LOGGER.info("config center URL is missing, skip to load configuration
from config center");
+ LOGGER.info("config center URL is not configured");
Review comment:
1.maybe print config key is better
2."skip to load configuration from config center", it's better to keep this
information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Log optimization
> ----------------
>
> Key: SCB-331
> URL: https://issues.apache.org/jira/browse/SCB-331
> Project: Apache ServiceComb
> Issue Type: Task
> Reporter: laijianbin
> Assignee: laijianbin
> Priority: Major
>
> public static DynamicWatchedConfiguration
> createConfigFromConfigCenter(Configuration localConfiguration) {
> if (localConfiguration.getProperty(configCenterUrlKey) == null)
> { LOGGER.info("config center URL is missing, skip to load configuration from
> config center"); return null; }
> changed to
> public static DynamicWatchedConfiguration
> createConfigFromConfigCenter(Configuration localConfiguration) {
> if (localConfiguration.getProperty(configCenterUrlKey) == null)
> { LOGGER.info("config center URL is not configured"); return null; }
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
