[ 
https://issues.apache.org/jira/browse/SCB-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363325#comment-16363325
 ] 

ASF GitHub Bot commented on SCB-339:
------------------------------------

little-cui commented on a change in pull request #280: SCB-339 The wrong 
statistics in micro-service
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/280#discussion_r168053123
 
 

 ##########
 File path: server/service/util/microservice_util.go
 ##########
 @@ -245,7 +245,7 @@ func GetOneDomainProjectServiceCount(ctx context.Context, 
domainProject string)
 }
 
 func GetOneDomainProjectInstanceCount(ctx context.Context, domainProject 
string) (int64, error) {
-       key := apt.GetInstanceRootKey(domainProject) + "/"
+       key := apt.GetInstanceRootKeyEndWithSeparator(domainProject)
 
 Review comment:
   这个修改方案没有根本解决问题,调用方依然需要知道是否要加/为前提,没有这个前提,就依然出现BUG

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The wrong statistics in micro-service
> -------------------------------------
>
>                 Key: SCB-339
>                 URL: https://issues.apache.org/jira/browse/SCB-339
>             Project: Apache ServiceComb
>          Issue Type: Bug
>          Components: Service-Center
>            Reporter: little-cui
>            Assignee: little-cui
>            Priority: Major
>             Fix For: service-center-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to