[ 
https://issues.apache.org/jira/browse/SCB-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363364#comment-16363364
 ] 

ASF GitHub Bot commented on SCB-327:
------------------------------------

WillemJiang commented on a change in pull request #555: [SCB-327] Update 
metrics publish data module (Re-organized)
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r168059325
 
 

 ##########
 File path: 
foundations/foundation-metrics/src/main/java/org/apache/servicecomb/foundation/metrics/publish/DefaultHealthCheckExtraData.java
 ##########
 @@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-package org.apache.servicecomb.metrics.common;
+package org.apache.servicecomb.foundation.metrics.publish;
 
 public class DefaultHealthCheckExtraData {
 
 Review comment:
   What's the relationship between the DefaultHealthCheckExtraData and 
HealthCheckResult.extraData?
   We don't need to use the String to store result,  it's easy to use toString 
method to turn the instance of HealthCheckExtraData into a string.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update metrics publish data module
> ----------------------------------
>
>                 Key: SCB-327
>                 URL: https://issues.apache.org/jira/browse/SCB-327
>             Project: Apache ServiceComb
>          Issue Type: Sub-task
>          Components: Java-Chassis
>    Affects Versions: java-chassis-1.0.0-m1
>            Reporter: yangyongzheng
>            Assignee: yangyongzheng
>            Priority: Major
>             Fix For: java-chassis-1.0.0-m1
>
>
> Change data publish from RegistryMetric model to map
>  adjust metrics publish format to spring cloud netflix style



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to