[ 
https://issues.apache.org/jira/browse/SCB-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363400#comment-16363400
 ] 

ASF GitHub Bot commented on SCB-327:
------------------------------------

WillemJiang commented on a change in pull request #555: [SCB-327] Update 
metrics publish data module (Re-organized)
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r168063945
 
 

 ##########
 File path: 
metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/core/monitor/RegistryMonitor.java
 ##########
 @@ -51,16 +48,14 @@ public ProducerInvocationMonitor 
getProducerInvocationMonitor(String operationNa
     return producerInvocationMonitors.computeIfAbsent(operationName, i -> new 
ProducerInvocationMonitor(operationName));
   }
 
-  public RegistryMetric toRegistryMetric(int windowTimeIndex) {
-    Map<String, ConsumerInvocationMetric> consumerInvocationMetrics = new 
HashMap<>();
+  public Map<String, Double> measure(int windowTimeIndex, boolean 
calculateLatency) {
+    Map<String, Double> measurements = new HashMap<>(systemMonitor.measure());
 
 Review comment:
   If we want measure the invocation monitor, we don't need to know if it 
consumerInvocationMonitor or producerInvocationMonitor.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update metrics publish data module
> ----------------------------------
>
>                 Key: SCB-327
>                 URL: https://issues.apache.org/jira/browse/SCB-327
>             Project: Apache ServiceComb
>          Issue Type: Sub-task
>          Components: Java-Chassis
>    Affects Versions: java-chassis-1.0.0-m1
>            Reporter: yangyongzheng
>            Assignee: yangyongzheng
>            Priority: Major
>             Fix For: java-chassis-1.0.0-m1
>
>
> Change data publish from RegistryMetric model to map
>  adjust metrics publish format to spring cloud netflix style



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to