[
https://issues.apache.org/jira/browse/SCB-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375402#comment-16375402
] ASF GitHub Bot commented on SCB-336: ------------------------------------ codecov-io commented on issue #279: SCB-336 1.add ut about find instance with tag 2.optimize find api URL: https://github.com/apache/incubator-servicecomb-service-center/pull/279#issuecomment-364032781 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279?src=pr&el=h1) Report > Merging [#279](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/268cba27f2ee6ff533ea94de12833c3052b1206d?src=pr&el=desc) will **decrease** coverage by `0.09%`. > The diff coverage is `80.85%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #279 +/- ## ======================================== - Coverage 70.39% 70.3% -0.1% ======================================== Files 17 17 Lines 3418 3431 +13 ======================================== + Hits 2406 2412 +6 - Misses 846 848 +2 - Partials 166 171 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [server/service/instances.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VzLmdv) | `71.11% <66.66%> (ø)` | :arrow_up: | | [server/service/util/rule\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9ydWxlX3V0aWwuZ28=) | `67.06% <81.81%> (-1.4%)` | :arrow_down: | | [server/service/util/instance\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv) | `49.09% <0%> (-0.63%)` | :arrow_down: | | [server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `75.43% <0%> (-0.59%)` | :arrow_down: | | [server/service/util/dependency.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5Lmdv) | `57.58% <0%> (-0.17%)` | :arrow_down: | | [server/service/microservices.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvbWljcm9zZXJ2aWNlcy5nbw==) | `74.6% <0%> (+0.15%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279?src=pr&el=footer). Last update [268cba2...eacecbf](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Can not filter instances with service tags > ------------------------------------------ > > Key: SCB-336 > URL: https://issues.apache.org/jira/browse/SCB-336 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center > Reporter: little-cui > Assignee: little-cui > Priority: Major > Fix For: service-center-1.0.0-m2 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
