[
https://issues.apache.org/jira/browse/SCB-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375406#comment-16375406
]
ASF GitHub Bot commented on SCB-327:
------------------------------------
zhengyangyong commented on a change in pull request #555: [SCB-327] Update
metrics publish data module (Re-organized)
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r170415566
##########
File path:
metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/core/publish/HealthCheckerPublisher.java
##########
@@ -60,16 +53,19 @@ private void init(HealthCheckerManager manager) {
@RequestMapping(path = "/", method = RequestMethod.GET)
@CrossOrigin
- public Map<String, HealthCheckResult> health() {
- return manager.check();
+ public boolean checkHealth() {
+ Map<String, HealthCheckResult> results = manager.check();
+ for (HealthCheckResult result : results.values()) {
+ if (!result.isHealthy()) {
+ return false;
+ }
+ }
+ return true;
}
- @ApiResponses({
- @ApiResponse(code = 400, response = String.class, message = "illegal
request content"),
- })
- @RequestMapping(path = "/{name}", method = RequestMethod.GET)
+ @RequestMapping(path = "/detail", method = RequestMethod.GET)
@CrossOrigin
- public HealthCheckResult healthWithName(@PathVariable(name = "name") String
name) {
- return manager.check(name);
+ public Map<String, HealthCheckResult> checkHealthDetail() {
Review comment:
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update metrics publish data module
> ----------------------------------
>
> Key: SCB-327
> URL: https://issues.apache.org/jira/browse/SCB-327
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
> Affects Versions: java-chassis-1.0.0-m1
> Reporter: yangyongzheng
> Assignee: yangyongzheng
> Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> Change data publish from RegistryMetric model to map
> adjust metrics publish format to spring cloud netflix style
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
