[
https://issues.apache.org/jira/browse/SCB-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385082#comment-16385082
]
ASF GitHub Bot commented on SCB-355:
------------------------------------
wujimin commented on a change in pull request #565: [SCB-355]If auth
failed,sc/cc will not connect server to reduce server pressure
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/565#discussion_r172046771
##########
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/task/MicroserviceInstanceRegisterTask.java
##########
@@ -56,6 +56,11 @@ public void
onMicroserviceRegisterTask(MicroserviceRegisterTask task) {
@Override
protected boolean doRegister() {
+ if (microserviceInstance.getServiceId() == null) {
Review comment:
why register microservice failed, but try to register microservice instance?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> As a operator, when sdk config a fault ak/sk on HuaweiCloud, then will auth
> token fail, but it continues to register, will cause may fault in server
> ----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SCB-355
> URL: https://issues.apache.org/jira/browse/SCB-355
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
> Reporter: jeho0815
> Assignee: jeho0815
> Priority: Major
>
> service center/ config center auth failed, then do not call remote service
> again, give a error log to user
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
