[ 
https://issues.apache.org/jira/browse/SCB-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16388896#comment-16388896
 ] 

ASF GitHub Bot commented on SCB-210:
------------------------------------

lijasonvip commented on a change in pull request #569: SCB-210 remove extra 
useless config item
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/569#discussion_r172722352
 
 

 ##########
 File path: 
dynamic-config/config-apollo/src/main/java/org/apache/servicecomb/config/archaius/sources/ApolloConfigurationSourceImpl.java
 ##########
 @@ -49,11 +49,21 @@
 
   private List<WatchedUpdateListener> listeners = new CopyOnWriteArrayList<>();
 
+  private static final String APOLLO_CONFIG_URL_KEY = 
"apollo.config.serverUri";
+
   public ApolloConfigurationSourceImpl() {
   }
 
   private final UpdateHandler updateHandler = new UpdateHandler();
 
+  @Override
+  public boolean isValidSource(Configuration localConfiguration) {
+    if (localConfiguration.getProperty(APOLLO_CONFIG_URL_KEY) == null){
 
 Review comment:
   Fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use map feature to design microservice yaml file to support control flag of 
> config center
> -----------------------------------------------------------------------------------------
>
>                 Key: SCB-210
>                 URL: https://issues.apache.org/jira/browse/SCB-210
>             Project: Apache ServiceComb
>          Issue Type: Sub-task
>          Components: Java-Chassis
>            Reporter: Bo Li
>            Assignee: Bo Li
>            Priority: Major
>
> check comment of wujimin at:
> https://github.com/apache/incubator-servicecomb-java-chassis/pull/489/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to