[
https://issues.apache.org/jira/browse/SCB-372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16389284#comment-16389284
]
ASF GitHub Bot commented on SCB-372:
------------------------------------
wujimin commented on a change in pull request #574: [SCB-372] support user set
metrics prometheus exporter address not only port
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/574#discussion_r172777876
##########
File path:
metrics/metrics-integration/metrics-prometheus/src/test/java/org/apache/servicecomb/metrics/prometheus/TestMetricsHttpPublisher.java
##########
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.metrics.prometheus;
+
+import
org.apache.servicecomb.foundation.common.exceptions.ServiceCombException;
+import org.junit.Assert;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.ExpectedException;
+
+public class TestMetricsHttpPublisher {
+
+ @Rule
+ public ExpectedException thrown = ExpectedException.none();
+
+ @Test
+ public void testBadPublishAddress() {
+ thrown.expect(ServiceCombException.class);
+ new MetricsHttpPublisher("a:b:c");
+ Assert.fail("testPublishAddress failed : a:b:c");
Review comment:
no need to write Assert.fail
because if ExpectedException not matched, it's also cause to be a failure
testcase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> support user set prometheus exporter address not only port
> ----------------------------------------------------------
>
> Key: SCB-372
> URL: https://issues.apache.org/jira/browse/SCB-372
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
> Affects Versions: java-chassis-1.0.0-m1
> Reporter: yangyongzheng
> Assignee: yangyongzheng
> Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> current user only can set metrics prometheus exporter port like :
> servicecomb.metrics.prometheus.port= 9696
> we may support user set full address like cse transport :
> servicecomb.metrics.prometheus.address= 0.0.0.0:9696
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
