[
https://issues.apache.org/jira/browse/SCB-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394108#comment-16394108
]
ASF GitHub Bot commented on SCB-381:
------------------------------------
wujimin commented on a change in pull request #583: [SCB-381] Fix
foundation-vertx UT failure
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/583#discussion_r173616568
##########
File path: foundations/foundation-vertx/pom.xml
##########
@@ -53,4 +53,21 @@
<artifactId>foundation-test-scaffolding</artifactId>
</dependency>
</dependencies>
+
+ <!--
+ Disable surefire forking for vertex, it causes the UT to fail
+ on some platforms(mainly linux).
+ -->
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <forkCount>1</forkCount>
+ <reuseForks>false</reuseForks>
Review comment:
not a good idea
should fix the root cause.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix foudation-vertx UT failure on linux
> ---------------------------------------
>
> Key: SCB-381
> URL: https://issues.apache.org/jira/browse/SCB-381
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
> Reporter: Yang Bo
> Assignee: Yang Bo
> Priority: Major
>
> The foudation-vertx's UT would fail on some linux platforms.
> createClientPool.createClientPool fails on
> TcpClientConnectionPool pool = factory.createClientPool();
> with NPE.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
