[
https://issues.apache.org/jira/browse/SCB-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394948#comment-16394948
]
ASF GitHub Bot commented on SCB-387:
------------------------------------
coveralls commented on issue #303: SCB-387 Add ASF headers for auto-generated
files
URL:
https://github.com/apache/incubator-servicecomb-service-center/pull/303#issuecomment-372212464
[](https://coveralls.io/builds/15922904)
Coverage increased (+0.2%) to 74.112% when pulling
**1b3a0128c7a9cecea6729efd10daad1489c4a85f on asifdxtreme:master** into
**bfe06665e640d4473ef68e54671d395e4f7ca3f6 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Somefiles are lacking ASF header in Service Center
> --------------------------------------------------
>
> Key: SCB-387
> URL: https://issues.apache.org/jira/browse/SCB-387
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Service-Center
> Reporter: Yang Bo
> Assignee: Mohammad Asif Siddiqui
> Priority: Major
> Fix For: service-center-1.0.0-m1
>
>
> The following files does not have ASF headers
> src:
> ./server/broker/broker.pb.go
> ./server/broker/broker.proto
> ./server/core/proto/services.pb.go
> ./server/core/proto/services.proto
> ./server/core/swagger/v3.yaml
> ./server/core/swagger/v4.yaml
> The pb.go files are generated by protobuf utility, perhaps we can exclude it
> for checking. But the .proto files should have the ASF header.
> bin:
> ./conf/app.conf
> The apache policy states that only files that have no creativity and some
> simple template files for code generation can have the header omitted. Other
> files should all have the header included.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
