[
https://issues.apache.org/jira/browse/SCB-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394949#comment-16394949
]
ASF GitHub Bot commented on SCB-387:
------------------------------------
codecov-io commented on issue #303: SCB-387 Add ASF headers for auto-generated
files
URL:
https://github.com/apache/incubator-servicecomb-service-center/pull/303#issuecomment-372212467
#
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr&el=h1)
Report
> Merging
[#303](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/bfe06665e640d4473ef68e54671d395e4f7ca3f6?src=pr&el=desc)
will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #303 +/- ##
=======================================
Coverage 70.39% 70.39%
=======================================
Files 17 17
Lines 3455 3455
=======================================
Hits 2432 2432
Misses 853 853
Partials 170 170
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr&el=tree)
| Coverage Δ | |
|---|---|---|
|
[server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv)
| `75.43% <0%> (-0.59%)` | :arrow_down: |
|
[server/service/rule.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvcnVsZS5nbw==)
| `77.25% <0%> (+0.42%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr&el=footer).
Last update
[bfe0666...1b3a012](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/303?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Somefiles are lacking ASF header in Service Center
> --------------------------------------------------
>
> Key: SCB-387
> URL: https://issues.apache.org/jira/browse/SCB-387
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Service-Center
> Reporter: Yang Bo
> Assignee: Mohammad Asif Siddiqui
> Priority: Major
> Fix For: service-center-1.0.0-m1
>
>
> The following files does not have ASF headers
> src:
> ./server/broker/broker.pb.go
> ./server/broker/broker.proto
> ./server/core/proto/services.pb.go
> ./server/core/proto/services.proto
> ./server/core/swagger/v3.yaml
> ./server/core/swagger/v4.yaml
> The pb.go files are generated by protobuf utility, perhaps we can exclude it
> for checking. But the .proto files should have the ASF header.
> bin:
> ./conf/app.conf
> The apache policy states that only files that have no creativity and some
> simple template files for code generation can have the header omitted. Other
> files should all have the header included.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
