[
https://issues.apache.org/jira/browse/SCB-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396651#comment-16396651
]
ASF GitHub Bot commented on SCB-382:
------------------------------------
WillemJiang closed pull request #584: [SCB-382] upgrade io.fabric8
docker-maven-plugin version and fix depends-on setting
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/584
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/demo/docker-run-config/pom.xml b/demo/docker-run-config/pom.xml
index b6586803d..52ba50f83 100644
--- a/demo/docker-run-config/pom.xml
+++ b/demo/docker-run-config/pom.xml
@@ -89,7 +89,7 @@
<port>8080:8080</port>
</ports>
<dependsOn>
- <dependsOn>service-center</dependsOn>
+ <container>service-center</container>
</dependsOn>
</run>
</image>
diff --git a/integration-tests/dynamic-config-tests/pom.xml
b/integration-tests/dynamic-config-tests/pom.xml
index 5c4f65d94..f0ab7c8fb 100644
--- a/integration-tests/dynamic-config-tests/pom.xml
+++ b/integration-tests/dynamic-config-tests/pom.xml
@@ -99,7 +99,9 @@
<port>apollo.config:8080</port>
<port>apollo.portal:8070</port>
</ports>
- <dependsOn>mysql</dependsOn>
+ <dependsOn>
+ <container>mysql</container>
+ </dependsOn>
</run>
</image>
</images>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting
> -------------------------------------------------------------------------
>
> Key: SCB-382
> URL: https://issues.apache.org/jira/browse/SCB-382
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
> Affects Versions: java-chassis-1.0.0-m1
> Reporter: yangyongzheng
> Assignee: yangyongzheng
> Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> more detail : [https://dmp.fabric8.io/#start-depends-on]
> {{ <dependsOn> <container>postgres</container>
> <container>logstash</container> </dependsOn>}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
