[
https://issues.apache.org/jira/browse/SCB-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404737#comment-16404737
]
ASF GitHub Bot commented on SCB-411:
------------------------------------
codecov-io commented on issue #310: SCB-411 SC can not check the reduplicate
endpoints when register with ID
URL:
https://github.com/apache/incubator-servicecomb-service-center/pull/310#issuecomment-373902301
#
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/310?src=pr&el=h1)
Report
> Merging
[#310](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/310?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/f8b3e7b95ef63709cfb933a3688a4714271ec518?src=pr&el=desc)
will **decrease** coverage by `0.39%`.
> The diff coverage is `56.91%`.
[](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/310?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #310 +/- ##
=========================================
- Coverage 70.33% 69.93% -0.4%
=========================================
Files 17 17
Lines 3452 3443 -9
=========================================
- Hits 2428 2408 -20
- Misses 853 864 +11
Partials 171 171
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/310?src=pr&el=tree)
| Coverage Δ | |
|---|---|---|
|
[server/service/util/instance\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/310/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv)
| `53.45% <41.66%> (+4.36%)` | :arrow_up: |
|
[server/service/instances.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/310/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VzLmdv)
| `67.28% <58.55%> (-3.84%)` | :arrow_down: |
|
[server/service/rule.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/310/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvcnVsZS5nbw==)
| `77.25% <0%> (+0.42%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/310?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/310?src=pr&el=footer).
Last update
[f8b3e7b...b10ffec](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/310?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> SC can not check the reduplicate endpoints when register with instanceId
> ------------------------------------------------------------------------
>
> Key: SCB-411
> URL: https://issues.apache.org/jira/browse/SCB-411
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Service-Center
> Reporter: little-cui
> Assignee: little-cui
> Priority: Major
> Fix For: service-center-1.0.0-m2
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
