[
https://issues.apache.org/jira/browse/SCB-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404789#comment-16404789
]
ASF GitHub Bot commented on SCB-417:
------------------------------------
asifdxtreme commented on a change in pull request #614: [SCB-417] delete
useless lines in readme
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/614#discussion_r175427311
##########
File path: samples/README.md
##########
@@ -7,20 +7,4 @@ It's the samples of Java chassis
4. code first sample
5. customer handler sample
6. extend metrics health checker sample
-7. write metrics data into separate text files sample
-
-## 1. Start the ServiceComb/Service Center
Review comment:
I think starting Service-Center should be there in Readme, as our samples
won't run without a working instance of Service-Center
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Update Readme in samples root
> -----------------------------
>
> Key: SCB-417
> URL: https://issues.apache.org/jira/browse/SCB-417
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
> Affects Versions: java-chassis-1.0.0-m1
> Reporter: yangyongzheng
> Assignee: yangyongzheng
> Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> remove this lines :
> ## 1. Start the ServiceComb/Service Center
> [how to start the service
> center](http://servicecomb.io/users/setup-environment/#)
> ## 2.Start the Microservice server
> ```bash
> mvn test -Pserver
> ```
> ## 3.Start the Microservice client
> ```bash
> mvn test -Pclient
> ```
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
