[
https://issues.apache.org/jira/browse/SCB-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408879#comment-16408879
]
ASF GitHub Bot commented on SCB-324:
------------------------------------
wujimin commented on a change in pull request #615: [SCB-324] Fault-Injection
handler implementation
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/615#discussion_r176285277
##########
File path:
handlers/handler-fault-injection/src/main/java/org/apache/servicecomb/faultinjection/FaultInjectionUtil.java
##########
@@ -0,0 +1,168 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.faultinjection;
+
+import static
org.apache.servicecomb.faultinjection.FaultInjectionConst.CONSUMER_FAULTINJECTION;
+import static
org.apache.servicecomb.faultinjection.FaultInjectionConst.CONSUMER_FAULTINJECTION_GLOBAL;
+import static
org.apache.servicecomb.faultinjection.FaultInjectionConst.CONSUMER_FAULTINJECTION_POLICY_PROTOCOLS;
+import static
org.apache.servicecomb.faultinjection.FaultInjectionConst.FAULT_INJECTION_DEFAULT_VALUE;
+
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicInteger;
+import java.util.concurrent.atomic.AtomicLong;
+
+import org.apache.servicecomb.core.Invocation;
+import org.apache.servicecomb.foundation.common.concurrent.ConcurrentHashMapEx;
+
+/**
+ * Handles the count for all request based key[transport + microservice
qualified name].
+ */
+public class FaultInjectionUtil {
+
+ // key is transport+operQualifiedName
+ private static Map<String, AtomicLong> requestCount = new
ConcurrentHashMapEx<>();
+
+ // key is config paramter
+ private static Map<String, AtomicInteger> configCenterValue = new
ConcurrentHashMapEx<>();
+
+ /**
+ * Returns total requests per provider for operational level.
+ *
+ * @param key
+ * transport+operational name
+ * @return long total requests
+ */
+ public static AtomicLong getOperMetTotalReq(String key) {
+ return requestCount.computeIfAbsent(key, p -> new AtomicLong(1));
+ }
+
+ /**
+ * Returns the map of config parameter key and values.
+ * @return value of config parameter map
+ */
+ public static Map<String, AtomicInteger> getConfigCenterMap() {
+ return configCenterValue;
+ }
+
+ /**
+ * Sets the value for given config parameter.
+ * @param key
+ * @param value
+ */
+ public static void setConfigCenterValue(String key, AtomicInteger value) {
+ configCenterValue.put(key, value);
+ }
+
+ /**
+ * Handles the reading fault injection configuration.
+ *
+ * @param invocation
+ * invocation of request
+ * @param key
+ * configuration key
+ * @return configuration value
+ */
+ public static int getFaultInjectionConfig(Invocation invocation, String key)
{
+ int value = 0;
+ String config;
+
+ // get the config base on priority.
operationName-->schema-->service-->global
+ String operationName = invocation.getOperationName();
+ String schema = invocation.getSchemaId();
+ String serviceName = invocation.getMicroserviceName();
+
+ config = CONSUMER_FAULTINJECTION + serviceName + ".schemas." + schema +
".operations." + operationName + "."
Review comment:
we can build config model to hold all the values
and when configuration changed then calculate the effect value
no need to concat and calculate everytimes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Chassis must support network failure simulation, so that I can developers can
> enhance the robustness of the app
> ---------------------------------------------------------------------------------------------------------------
>
> Key: SCB-324
> URL: https://issues.apache.org/jira/browse/SCB-324
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
> Reporter: sukesh
> Assignee: sukesh
> Priority: Minor
> Fix For: java-chassis-1.0.0-m2
>
>
> Add new handler for fault injection.
> 1) If handler 'fault-injection' is added in application property
> file(microservice.yaml) then fault-injection handler should include in
> handler chain.
> 2) When handler is called read the configuration and listen the configuration
> event related to fault inject. The sample configuration file is in next slide.
> 3) The configuration mainly consist
> -delay
> -abort
> *delay:*can set the delay for requests based on percentage configured. The
> unit is ms. The delay percentage default value is 100%
> *abort*: Abort the requests based on percentage configured. For rest
> transport protocol error code can be configurable(500, 421) and highway
> protocol does not support for error return. The abort percentage default
> value is 100%
> 4) This features currently supports at consumer side.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
