[
https://issues.apache.org/jira/browse/SCB-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420293#comment-16420293
]
ASF GitHub Bot commented on SCB-444:
------------------------------------
liubao68 commented on a change in pull request #625: [SCB-444]try to optimize
autoDiscovery function
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/625#discussion_r178256282
##########
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/IpPortManager.java
##########
@@ -50,6 +50,11 @@
private boolean autoDiscoveryInited = false;
+ public int getMaxRetryTimes() {
+ return currentAvailableIndex.get() < 2 ? 2 : currentAvailableIndex.get();
Review comment:
This logic is not correct. Assume current index is 2, and failed, index
becomes 0. In this situation, only retried 2 and you expect 3 times
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> try to optimize autodiscovery function
> --------------------------------------
>
> Key: SCB-444
> URL: https://issues.apache.org/jira/browse/SCB-444
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
> Affects Versions: java-chassis-1.0.0-m2
> Reporter: WeiChao
> Assignee: TaoMeng
> Priority: Minor
> Fix For: java-chassis-1.0.0-m2
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
