[
https://issues.apache.org/jira/browse/SCB-385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421507#comment-16421507
]
ASF GitHub Bot commented on SCB-385:
------------------------------------
WillemJiang commented on a change in pull request #628: [SCB-385] Metrics
publisher switch to new mechanism
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/628#discussion_r178444112
##########
File path:
demo/demo-springmvc/springmvc-client/src/main/java/org/apache/servicecomb/demo/springmvc/client/SpringmvcClient.java
##########
@@ -96,20 +96,14 @@ public static void run() {
}
//0.5.0 later version metrics integration test
- try {
- Thread.sleep(1000);
- @SuppressWarnings("unchecked")
- Map<String, Double> metrics = restTemplate.getForObject(prefix +
"/metrics", Map.class);
-
- TestMgr
- .check(true, metrics.get("jvm(name=heapUsed,statistic=gauge)") != 0);
- TestMgr.check(true, metrics.size() > 0);
- TestMgr.check(true,
- metrics.get(
-
"servicecomb.invocation(operation=springmvc.codeFirst.saySomething,role=producer,stage=total,statistic=count,status=200)")
>= 0);
- } catch (Exception e) {
- TestMgr.check("true", "false");
- }
+ @SuppressWarnings("unchecked")
+ Map<String, Double> metrics = restTemplate.getForObject(prefix +
"/metrics", Map.class);
+
+// TestMgr.check(true, metrics.get("jvm(name=heapUsed,statistic=gauge)") !=
0);
+ TestMgr.check(true, metrics.size() > 0);
+ TestMgr.check(true,
+ metrics.get(
+
"servicecomb.invocation(operation=springmvc.codeFirst.saySomething,role=PRODUCER,stage=total,statistic=count,status=200,transport=highway)")
>= 0);
Review comment:
Can we use the lower case in the role tage?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> metrics publisher switch to new mechanism
> -----------------------------------------
>
> Key: SCB-385
> URL: https://issues.apache.org/jira/browse/SCB-385
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
> Reporter: wujimin
> Assignee: wujimin
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
