[ 
https://issues.apache.org/jira/browse/SCB-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429667#comment-16429667
 ] 

ASF GitHub Bot commented on SCB-189:
------------------------------------

lijasonvip commented on a change in pull request #636: SCB-189 fix CI problems 
and warnings for feature support async restTeā€¦
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/636#discussion_r179939180
 
 

 ##########
 File path: 
providers/provider-springmvc/src/test/java/org/apache/servicecomb/provider/springmvc/reference/async/CseAsyncRequestCallbackTest.java
 ##########
 @@ -28,27 +28,24 @@
   @Test
   public void testNormal() {
     CseAsyncClientHttpRequest request = new CseAsyncClientHttpRequest();
-    @SuppressWarnings("unchecked")
-    CseAsyncRequestCallback cb = new CseAsyncRequestCallback(null);
+    CseAsyncRequestCallback<HttpEntity<String>> cb = new 
CseAsyncRequestCallback<HttpEntity<String>>(null);
 
 Review comment:
   As HttpEntity is still a raw type here, this could cause a warning again.
   how about `CseAsyncRequestCallback<HttpEntity<?>> cb = new 
CseAsyncRequestCallback<>(null);`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> support async restTemplate
> --------------------------
>
>                 Key: SCB-189
>                 URL: https://issues.apache.org/jira/browse/SCB-189
>             Project: Apache ServiceComb
>          Issue Type: Sub-task
>          Components: Java-Chassis
>            Reporter: wujimin
>            Assignee: Bo Li
>            Priority: Major
>             Fix For: service-center-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to