[
https://issues.apache.org/jira/browse/SCB-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430001#comment-16430001
]
ASF GitHub Bot commented on SCB-456:
------------------------------------
liubao68 commented on a change in pull request #632: [SCB-456]Provider a way to
input configuration from a Map
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/632#discussion_r179982646
##########
File path:
foundations/foundation-config/src/main/java/org/apache/servicecomb/config/ConfigUtil.java
##########
@@ -52,9 +52,15 @@
private static final String MICROSERVICE_CONFIG_LOADER_KEY =
"cse-microservice-config-loader";
+ private static ConfigModel model = new ConfigModel();
+
private ConfigUtil() {
}
+ public static void setConfigs(Map<String, Object> config) {
Review comment:
I think if we can provide a more convenient method to add configs . e.g.
public static void addConfig(String k, Object v)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Provider a way to input configuration from a Map, instead of
> micreservice.yaml
> -------------------------------------------------------------------------------
>
> Key: SCB-456
> URL: https://issues.apache.org/jira/browse/SCB-456
> Project: Apache ServiceComb
> Issue Type: Task
> Reporter: Minzhi Yan
> Assignee: Minzhi Yan
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
