[ 
https://issues.apache.org/jira/browse/SCB-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430130#comment-16430130
 ] 

ASF GitHub Bot commented on SCB-422:
------------------------------------

wujimin commented on a change in pull request #639: [SCB-422] prometheus switch 
to new mechanism
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/639#discussion_r179996747
 
 

 ##########
 File path: metrics/metrics-integration/metrics-prometheus/pom.xml
 ##########
 @@ -43,7 +42,10 @@
       <groupId>org.apache.servicecomb</groupId>
       <artifactId>metrics-core</artifactId>
     </dependency>
-
+    <dependency>
 
 Review comment:
   why test?
   all servicecomb measurement come from metrics-core.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> add executor metrics, not just queue size
> -----------------------------------------
>
>                 Key: SCB-422
>                 URL: https://issues.apache.org/jira/browse/SCB-422
>             Project: Apache ServiceComb
>          Issue Type: Sub-task
>          Components: Java-Chassis
>            Reporter: wujimin
>            Assignee: wujimin
>            Priority: Major
>             Fix For: java-chassis-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to