[ 
https://issues.apache.org/jira/browse/SCB-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431926#comment-16431926
 ] 

yangyongzheng commented on SCB-466:
-----------------------------------

I had try submitted a new exporter module in order to simplify code but not 
accepted : https://github.com/prometheus/client_java/pull/370
We can close this issues now

> improve metrics prometheus and contribute to 
> https://github.com/prometheus/client_java
> --------------------------------------------------------------------------------------
>
>                 Key: SCB-466
>                 URL: https://issues.apache.org/jira/browse/SCB-466
>             Project: Apache ServiceComb
>          Issue Type: Improvement
>          Components: Java-Chassis
>            Reporter: wujimin
>            Priority: Major
>
> currently we only convert spectator measurement to prometheus Sample
> but lost sample type
>  
> before we contribute the code, we should improve the converter better, like: 
> https://github.com/prometheus/client_java/blob/master/simpleclient_dropwizard/src/main/java/io/prometheus/client/dropwizard/DropwizardExports.java



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to