[ 
https://issues.apache.org/jira/browse/SCB-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432089#comment-16432089
 ] 

ASF GitHub Bot commented on SCB-473:
------------------------------------

codecov-io commented on issue #326: [SCB-473][sc]delete service, should delete 
dependency key
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/326#issuecomment-380063602
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/326?src=pr&el=h1)
 Report
   > Merging 
[#326](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/326?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/7650f35df50d5350c5ed247082dd0d37e3352bbd?src=pr&el=desc)
 will **decrease** coverage by `0.24%`.
   > The diff coverage is `88.88%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/326/graphs/tree.svg?height=150&width=650&token=GAaF7zrg8R&src=pr)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/326?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #326      +/-   ##
   ==========================================
   - Coverage   69.73%   69.49%   -0.25%     
   ==========================================
     Files          17       17              
     Lines        3426     3435       +9     
   ==========================================
   - Hits         2389     2387       -2     
   - Misses        871      883      +12     
   + Partials      166      165       -1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/326?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[server/service/util/instance\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/326/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv)
 | `47.75% <ø> (ø)` | :arrow_up: |
   | 
[server/service/util/dependency.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/326/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5Lmdv)
 | `56.68% <88.88%> (-1.11%)` | :arrow_down: |
   | 
[server/service/instances.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/326/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VzLmdv)
 | `68.21% <0%> (-0.18%)` | :arrow_down: |
   | 
[server/service/rule.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/326/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvcnVsZS5nbw==)
 | `77.25% <0%> (+0.42%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/326?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/326?src=pr&el=footer).
 Last update 
[7650f35...aae3f88](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/326?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> delete service, should delete dependency key
> --------------------------------------------
>
>                 Key: SCB-473
>                 URL: https://issues.apache.org/jira/browse/SCB-473
>             Project: Apache ServiceComb
>          Issue Type: Bug
>          Components: Service-Center
>    Affects Versions: service-center-1.0.0-m1
>            Reporter: aseTo2016
>            Priority: Major
>             Fix For: service-center-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to