[ 
https://issues.apache.org/jira/browse/SCB-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436687#comment-16436687
 ] 

ASF GitHub Bot commented on SCB-470:
------------------------------------

liubao68 commented on a change in pull request #641: [SCB-470] add spring boot 
starter provider archetype
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/641#discussion_r181269775
 
 

 ##########
 File path: 
archetypes/business-service-spring-boot-starter/src/main/resources/microservice.yaml
 ##########
 @@ -0,0 +1,43 @@
+## ---------------------------------------------------------------------------
+## Licensed to the Apache Software Foundation (ASF) under one or more
+## contributor license agreements.  See the NOTICE file distributed with
+## this work for additional information regarding copyright ownership.
+## The ASF licenses this file to You under the Apache License, Version 2.0
+## (the "License"); you may not use this file except in compliance with
+## the License.  You may obtain a copy of the License at
+##
+##      http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+## ---------------------------------------------------------------------------
+
+#More details can be found :
+# 1.http://servicecomb.incubator.apache.org/users/service-definition/
+# 2.http://servicecomb.incubator.apache.org/users/service-configurations/
+# 3.http://servicecomb.incubator.apache.org/users/communicate-protocol/
+
+#Indicates an application name
+APPLICATION_ID: business
+service_description:
+#Indicates a microservice name
+#The microservice name should be unique within an application.
+#The name can contain digits, uppercase and lowercase letters, hyphens(-), 
underscores(_), and periods(.); and can neither start nor end with punctuations.
+#The naming rule is as follows: 
^[a-zA-Z0-9]+$|^[a-zA-Z0-9][a-zA-Z0-9_-.]*[a-zA-Z0-9]$.
+  name: business-service
+#Indicates a service version
+  version: 1.0.0
+cse:
+  service:
+  #Specifies the service center IP address.
+    registry:
+      address: http://127.0.0.1:30100
+  #Specifies the rest transport listening IP address.
+  rest:
 
 Review comment:
   As mentioned in above comments, this is quite bad practice to integrate with 
Spring Boot/Cloud. Because it causes a lot of misunderstanding about embedded 
tomcat and servlet containers and The Spring MVC framework. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Provide Maven Archetype of business-service-spring-boot-starter
> ---------------------------------------------------------------
>
>                 Key: SCB-470
>                 URL: https://issues.apache.org/jira/browse/SCB-470
>             Project: Apache ServiceComb
>          Issue Type: Sub-task
>          Components: Java-Chassis
>    Affects Versions: java-chassis-1.0.0-m2
>            Reporter: yangyongzheng
>            Assignee: yangyongzheng
>            Priority: Major
>             Fix For: java-chassis-1.0.0-m2
>
>
> This Archetype for create a common microservice using 
> spring-boot-starter-provider.
> It's contains :
> 1.All necessary dependencies in pom.
> 2.An HelloEndpoint provider using springmvc mode.
> 3.Default microservice.yaml.
> 4.Provider bean xml Included spring component-scan.
> 5.An HelloConsumer using springmvc mode.
> 6.Readme file teach user what can be done further.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to