[ 
https://issues.apache.org/jira/browse/SCB-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436768#comment-16436768
 ] 

ASF GitHub Bot commented on SCB-481:
------------------------------------

WillemJiang commented on issue #647: [SCB-481]Fix qps handler compatible issues 
due to assumption to schema ids not contains dot
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/647#issuecomment-381015747
 
 
   @liubao68  Please update the commit message with JIRA number on it, 
otherwise we have to merge this patch in Squash way.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix qps handler assertion errors when schemaid or microservice name contails 
> . (dot)
> ------------------------------------------------------------------------------------
>
>                 Key: SCB-481
>                 URL: https://issues.apache.org/jira/browse/SCB-481
>             Project: Apache ServiceComb
>          Issue Type: Bug
>          Components: Java-Chassis
>            Reporter: liubao
>            Priority: Major
>
> As now we have default schema ids generate by @RpcContext and other. Qps 
> handler assumes and assert schema id do not have . (dot) will cause 
> compatible issues. Now we need to make it work. 
>  
> If we need have conventions for name, leave it to future discussion.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to