[ 
https://issues.apache.org/jira/browse/SCB-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16438956#comment-16438956
 ] 

ASF GitHub Bot commented on SCB-292:
------------------------------------

wujimin commented on a change in pull request #627: [SCB-292] chassis support 
standard parameter validation
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/627#discussion_r181615715
 
 

 ##########
 File path: 
demo/demo-jaxrs/jaxrs-client/src/main/java/org/apache/servicecomb/demo/jaxrs/client/JaxrsClient.java
 ##########
 @@ -179,6 +180,8 @@ private static void testValidatorAddFail(RestTemplate 
template, String cseUrlPre
     } catch (InvocationException e) {
       isExcep = true;
       TestMgr.check(400, e.getStatus().getStatusCode());
+      TestMgr.check(Status.BAD_REQUEST, e.getReasonPhrase());
+      TestMgr.check(true, 
e.getErrorData().toString().contains("ConstraintViolationImpl"));
 
 Review comment:
   why use contains logic, not verity the full message

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> As a developer, I want to use annotation to validate input parameter
> --------------------------------------------------------------------
>
>                 Key: SCB-292
>                 URL: https://issues.apache.org/jira/browse/SCB-292
>             Project: Apache ServiceComb
>          Issue Type: New Feature
>          Components: Java-Chassis
>            Reporter: wujimin
>            Assignee: sukesh
>            Priority: Major
>             Fix For: java-chassis-1.0.0-m2
>
>
> move fromĀ https://servicecomb.atlassian.net/browse/JAV-475



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to