[ 
https://issues.apache.org/jira/browse/SCB-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16442562#comment-16442562
 ] 

ASF GitHub Bot commented on SCB-474:
------------------------------------

wujimin commented on a change in pull request #658: [SCB-474] add endpoint 
filter (only rest endpoints) for zuul integration
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/658#discussion_r182439425
 
 

 ##########
 File path: 
spring-boot-starter/spring-boot-starter-discovery/src/main/java/org/apache/servicecomb/springboot/starter/discovery/CseRibbonEndpointDiscoveryFilter.java
 ##########
 @@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.springboot.starter.discovery;
+
+import org.apache.servicecomb.core.filter.EndpointDiscoveryFilter;
+import org.apache.servicecomb.serviceregistry.discovery.DiscoveryContext;
+import org.apache.servicecomb.serviceregistry.discovery.DiscoveryTreeNode;
+
+public class CseRibbonEndpointDiscoveryFilter extends EndpointDiscoveryFilter {
 
 Review comment:
   better extend from AbstractEndpointDiscoveryFilter
   and createEndpoint return com.netflix.loadbalancer.Server

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> 使用zuul做网关进行路由,当同一个微服务接口同时开放rest和highway方式时,出现无法调用情况。
> ----------------------------------------------------
>
>                 Key: SCB-474
>                 URL: https://issues.apache.org/jira/browse/SCB-474
>             Project: Apache ServiceComb
>          Issue Type: Bug
>          Components: Java-Chassis
>    Affects Versions: java-chassis-1.0.0-m1
>            Reporter: zhousujan
>            Assignee: yangyongzheng
>            Priority: Major
>             Fix For: java-chassis-1.0.0-m2
>
>
> 使用zuul做网关进行路由,当同一个微服务接口同时开放rest和highway方式时,出现无法调用情况。经过定位,发现zuul能够把同一个微服务暴露的两种接入方式都获取到一个服务列表中,zuul默认使用轮询的方式进行路由,当轮询到rest方式时,能够正常调用;轮询到highway的地址时,必定报错。



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to