[
https://issues.apache.org/jira/browse/SCB-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443421#comment-16443421
]
ASF GitHub Bot commented on SCB-483:
------------------------------------
liubao68 commented on a change in pull request #653: [SCB-483] Springmvc rest
vertx file download
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#discussion_r182612283
##########
File path:
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/filter/inner/ServerRestArgsFilter.java
##########
@@ -50,7 +54,7 @@ public Response afterReceiveRequest(Invocation invocation,
HttpServletRequestEx
}
@Override
- public void beforeSendResponse(Invocation invocation, HttpServletResponseEx
responseEx) {
+ public CompletableFuture<Void> asyncBeforeSendResponse(Invocation
invocation, HttpServletResponseEx responseEx) {
Review comment:
I think beforeSendResponseAsync is a better name
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> springmvc over transport rest vertx support file download
> ---------------------------------------------------------
>
> Key: SCB-483
> URL: https://issues.apache.org/jira/browse/SCB-483
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
> Reporter: wujimin
> Assignee: wujimin
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
