[ https://issues.apache.org/jira/browse/SCB-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16455983#comment-16455983 ]
ASF GitHub Bot commented on SCB-514: ------------------------------------ liubao68 closed pull request #675: [SCB-514] Warning as error URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/675 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/RestObjectMapper.java b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/RestObjectMapper.java index fb76c901d..6dc1bbb01 100644 --- a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/RestObjectMapper.java +++ b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/RestObjectMapper.java @@ -26,10 +26,7 @@ import com.fasterxml.jackson.databind.ObjectMapper; import com.fasterxml.jackson.databind.SerializationFeature; import com.fasterxml.jackson.databind.type.TypeFactory; -import com.fasterxml.jackson.databind.util.ISO8601DateFormat; -import com.fasterxml.jackson.databind.util.ISO8601Utils; -@SuppressWarnings("deprecation") public final class RestObjectMapper extends ObjectMapper { public static final RestObjectMapper INSTANCE = new RestObjectMapper(); @@ -37,15 +34,16 @@ private static final JavaType STRING_JAVA_TYPE = TypeFactory.defaultInstance().constructType(String.class); + @SuppressWarnings("deprecation") private RestObjectMapper() { // swagger中要求date使用ISO8601格式传递,这里与之做了功能绑定,这在cse中是没有问题的 - setDateFormat(new ISO8601DateFormat() { + setDateFormat(new com.fasterxml.jackson.databind.util.ISO8601DateFormat() { private static final long serialVersionUID = 7798938088541203312L; // to support millis @Override public StringBuffer format(Date date, StringBuffer toAppendTo, FieldPosition fieldPosition) { - String value = ISO8601Utils.format(date, true); + String value = com.fasterxml.jackson.databind.util.ISO8601Utils.format(date, true); toAppendTo.append(value); return toAppendTo; } diff --git a/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/param/TestCookieProcessor.java b/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/param/TestCookieProcessor.java index 16a263675..98fa39c09 100644 --- a/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/param/TestCookieProcessor.java +++ b/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/param/TestCookieProcessor.java @@ -30,14 +30,12 @@ import org.junit.Test; import com.fasterxml.jackson.databind.type.TypeFactory; -import com.fasterxml.jackson.databind.util.ISO8601Utils; import mockit.Expectations; import mockit.Mock; import mockit.MockUp; import mockit.Mocked; -@SuppressWarnings("deprecation") public class TestCookieProcessor { @Mocked HttpServletRequest request; @@ -103,10 +101,11 @@ public void testGetValueCookiesFound() throws Exception { Assert.assertEquals("c1v", value); } + @SuppressWarnings("deprecation") @Test public void testGetValueCookiesDate() throws Exception { Date date = new Date(); - String strDate = ISO8601Utils.format(date); + String strDate = com.fasterxml.jackson.databind.util.ISO8601Utils.format(date); Cookie[] cookies = new Cookie[] {new Cookie("c1", strDate)}; new Expectations() { { @@ -117,7 +116,7 @@ public void testGetValueCookiesDate() throws Exception { CookieProcessor processor = createProcessor("c1", Date.class); Object value = processor.getValue(request); - Assert.assertEquals(strDate, ISO8601Utils.format((Date) value)); + Assert.assertEquals(strDate, com.fasterxml.jackson.databind.util.ISO8601Utils.format((Date) value)); } @Test @@ -132,7 +131,8 @@ public void testSetValue() throws Exception { @Test public void testSetValueDate() throws Exception { Date date = new Date(); - String strDate = ISO8601Utils.format(date, true); + @SuppressWarnings("deprecation") + String strDate = com.fasterxml.jackson.databind.util.ISO8601Utils.format(date, true); createClientRequest(); diff --git a/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/param/TestFormProcessor.java b/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/param/TestFormProcessor.java index e204d91ed..efded340e 100644 --- a/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/param/TestFormProcessor.java +++ b/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/param/TestFormProcessor.java @@ -33,14 +33,12 @@ import org.junit.Test; import com.fasterxml.jackson.databind.type.TypeFactory; -import com.fasterxml.jackson.databind.util.ISO8601Utils; import mockit.Expectations; import mockit.Mock; import mockit.MockUp; import mockit.Mocked; -@SuppressWarnings("deprecation") public class TestFormProcessor { @Mocked HttpServletRequest request; @@ -93,10 +91,11 @@ public void testGetValueNormal() throws Exception { } + @SuppressWarnings("deprecation") @Test public void testGetValueNormalDate() throws Exception { Date date = new Date(); - String strDate = ISO8601Utils.format(date); + String strDate = com.fasterxml.jackson.databind.util.ISO8601Utils.format(date); new Expectations() { { request.getParameter("name"); @@ -106,7 +105,7 @@ public void testGetValueNormalDate() throws Exception { ParamValueProcessor processor = createProcessor("name", Date.class); Object value = processor.getValue(request); - Assert.assertEquals(strDate, ISO8601Utils.format((Date) value)); + Assert.assertEquals(strDate, com.fasterxml.jackson.databind.util.ISO8601Utils.format((Date) value)); } @Test diff --git a/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/param/TestHeaderProcessor.java b/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/param/TestHeaderProcessor.java index 5a9d13ac9..cb3edb988 100644 --- a/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/param/TestHeaderProcessor.java +++ b/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/param/TestHeaderProcessor.java @@ -34,14 +34,12 @@ import org.junit.Test; import com.fasterxml.jackson.databind.type.TypeFactory; -import com.fasterxml.jackson.databind.util.ISO8601Utils; import mockit.Expectations; import mockit.Mock; import mockit.MockUp; import mockit.Mocked; -@SuppressWarnings("deprecation") public class TestHeaderProcessor { @Mocked HttpServletRequest request; @@ -78,10 +76,11 @@ public void testGetValueNormal() throws Exception { } + @SuppressWarnings("deprecation") @Test public void testGetValueNormalDate() throws Exception { Date date = new Date(); - String strDate = ISO8601Utils.format(date); + String strDate = com.fasterxml.jackson.databind.util.ISO8601Utils.format(date); new Expectations() { { request.getHeader("h1"); @@ -91,7 +90,7 @@ public void testGetValueNormalDate() throws Exception { HeaderProcessor processor = createProcessor("h1", Date.class); Object value = processor.getValue(request); - Assert.assertEquals(strDate, ISO8601Utils.format((Date) value)); + Assert.assertEquals(strDate, com.fasterxml.jackson.databind.util.ISO8601Utils.format((Date) value)); } @Test @@ -174,7 +173,8 @@ public void testSetValueNull() throws Exception { @Test public void testSetValueDate() throws Exception { Date date = new Date(); - String strDate = ISO8601Utils.format(date, true); + @SuppressWarnings("deprecation") + String strDate = com.fasterxml.jackson.databind.util.ISO8601Utils.format(date, true); createClientRequest(); diff --git a/demo/demo-crossapp/crossapp-client/src/main/java/org/apache/servicecomb/demo/crossapp/CrossappBootListener.java b/demo/demo-crossapp/crossapp-client/src/main/java/org/apache/servicecomb/demo/crossapp/CrossappBootListener.java index 3d912c4f8..491a5357f 100644 --- a/demo/demo-crossapp/crossapp-client/src/main/java/org/apache/servicecomb/demo/crossapp/CrossappBootListener.java +++ b/demo/demo-crossapp/crossapp-client/src/main/java/org/apache/servicecomb/demo/crossapp/CrossappBootListener.java @@ -18,17 +18,17 @@ package org.apache.servicecomb.demo.crossapp; import org.apache.servicecomb.core.BootListener; -import org.apache.servicecomb.core.definition.loader.DynamicSchemaLoader; import org.springframework.stereotype.Component; -@SuppressWarnings("deprecation") @Component public class CrossappBootListener implements BootListener { + @SuppressWarnings("deprecation") @Override public void onBootEvent(BootEvent event) { if (EventType.BEFORE_CONSUMER_PROVIDER.equals(event.getEventType())) { // 动态注册schemas目录下面的契约到当前服务 - DynamicSchemaLoader.INSTANCE.registerSchemas("appServer:appService", "classpath*:schemas/*.yaml"); + org.apache.servicecomb.core.definition.loader.DynamicSchemaLoader.INSTANCE.registerSchemas("appServer:appService", + "classpath*:schemas/*.yaml"); } } } diff --git a/demo/demo-crossapp/crossapp-server/src/main/java/org/apache/servicecomb/demo/crossapp/CrossappBootListener.java b/demo/demo-crossapp/crossapp-server/src/main/java/org/apache/servicecomb/demo/crossapp/CrossappBootListener.java index f129642bb..8c8aa82f8 100644 --- a/demo/demo-crossapp/crossapp-server/src/main/java/org/apache/servicecomb/demo/crossapp/CrossappBootListener.java +++ b/demo/demo-crossapp/crossapp-server/src/main/java/org/apache/servicecomb/demo/crossapp/CrossappBootListener.java @@ -18,17 +18,17 @@ package org.apache.servicecomb.demo.crossapp; import org.apache.servicecomb.core.BootListener; -import org.apache.servicecomb.core.definition.loader.DynamicSchemaLoader; import org.springframework.stereotype.Component; -@SuppressWarnings("deprecation") @Component public class CrossappBootListener implements BootListener { + @SuppressWarnings("deprecation") @Override public void onBootEvent(BootEvent event) { if (EventType.BEFORE_PRODUCER_PROVIDER.equals(event.getEventType())) { // 动态注册schemas目录下面的契约到当前服务 - DynamicSchemaLoader.INSTANCE.registerSchemas("classpath*:schemas/*.yaml"); + org.apache.servicecomb.core.definition.loader.DynamicSchemaLoader.INSTANCE + .registerSchemas("classpath*:schemas/*.yaml"); } } } diff --git a/demo/demo-springmvc/springmvc-client/src/main/java/org/apache/servicecomb/demo/springmvc/client/TestGeneric.java b/demo/demo-springmvc/springmvc-client/src/main/java/org/apache/servicecomb/demo/springmvc/client/TestGeneric.java index 3ca0a570e..82103e8d9 100644 --- a/demo/demo-springmvc/springmvc-client/src/main/java/org/apache/servicecomb/demo/springmvc/client/TestGeneric.java +++ b/demo/demo-springmvc/springmvc-client/src/main/java/org/apache/servicecomb/demo/springmvc/client/TestGeneric.java @@ -28,9 +28,6 @@ import org.springframework.http.HttpStatus; import org.springframework.web.client.RestTemplate; -import com.fasterxml.jackson.databind.util.ISO8601Utils; - -@SuppressWarnings("deprecation") public class TestGeneric { private CodeFirstSpringmvcIntf intf; @@ -70,16 +67,18 @@ private void testGenericEnum_rest() { TestMgr.check(HttpStatus.class, result.value.getClass()); } - @SuppressWarnings("unchecked") + @SuppressWarnings({"unchecked", "deprecation"}) private void testGenericDate_rest() { Generic<Date> generic = new Generic<>(); generic.value = new Date(1001); Generic<Date> result = intf.testGenericDate(generic); - TestMgr.check("1970-01-01T00:00:01.001Z", ISO8601Utils.format(result.value, true)); + TestMgr.check("1970-01-01T00:00:01.001Z", + com.fasterxml.jackson.databind.util.ISO8601Utils.format(result.value, true)); TestMgr.check(Date.class, result.value.getClass()); result = restTemplate.postForObject(prefix + "/genericDate", generic, Generic.class); - TestMgr.check("1970-01-01T00:00:01.001Z", ISO8601Utils.format(result.value, true)); + TestMgr.check("1970-01-01T00:00:01.001Z", + com.fasterxml.jackson.databind.util.ISO8601Utils.format(result.value, true)); TestMgr.check(Date.class, result.value.getClass()); } diff --git a/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/http/AbstractHttpServletRequest.java b/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/http/AbstractHttpServletRequest.java index 956f31bc2..b4bea0e9d 100644 --- a/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/http/AbstractHttpServletRequest.java +++ b/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/http/AbstractHttpServletRequest.java @@ -171,6 +171,7 @@ public RequestDispatcher getRequestDispatcher(String path) { } @Override + @Deprecated public String getRealPath(String path) { throw new Error("not supported method"); } @@ -357,6 +358,7 @@ public boolean isRequestedSessionIdFromURL() { } @Override + @Deprecated public boolean isRequestedSessionIdFromUrl() { throw new Error("not supported method"); } diff --git a/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/http/AbstractHttpServletResponse.java b/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/http/AbstractHttpServletResponse.java index 21404299d..8b1a9a6a4 100644 --- a/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/http/AbstractHttpServletResponse.java +++ b/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/http/AbstractHttpServletResponse.java @@ -134,11 +134,13 @@ public String encodeRedirectURL(String url) { } @Override + @Deprecated public String encodeUrl(String url) { throw new Error("not supported method"); } @Override + @Deprecated public String encodeRedirectUrl(String url) { throw new Error("not supported method"); } @@ -194,6 +196,7 @@ public void setStatus(int sc) { } @Override + @Deprecated public void setStatus(int sc, String sm) { throw new Error("not supported method"); } diff --git a/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/http/VertxServerResponseToHttpServletResponse.java b/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/http/VertxServerResponseToHttpServletResponse.java index ed776093e..75bf693dc 100644 --- a/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/http/VertxServerResponseToHttpServletResponse.java +++ b/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/http/VertxServerResponseToHttpServletResponse.java @@ -62,6 +62,7 @@ public void setContentType(String type) { } @Override + @Deprecated public void setStatus(int sc, String sm) { serverResponse.setStatusCode(sc); serverResponse.setStatusMessage(sm); diff --git a/foundations/foundation-vertx/src/test/java/org/apache/servicecomb/foundation/vertx/http/TestVertxServerResponseToHttpServletResponse.java b/foundations/foundation-vertx/src/test/java/org/apache/servicecomb/foundation/vertx/http/TestVertxServerResponseToHttpServletResponse.java index 6afd96495..0626dab5c 100644 --- a/foundations/foundation-vertx/src/test/java/org/apache/servicecomb/foundation/vertx/http/TestVertxServerResponseToHttpServletResponse.java +++ b/foundations/foundation-vertx/src/test/java/org/apache/servicecomb/foundation/vertx/http/TestVertxServerResponseToHttpServletResponse.java @@ -191,6 +191,7 @@ public void setContentType() { Assert.assertEquals("json", headers.get(HttpHeaders.CONTENT_TYPE)); } + @SuppressWarnings("deprecation") @Test public void setStatus() { response.setStatus(222, "test"); diff --git a/handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/HystrixCommandPropertiesExt.java b/handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/HystrixCommandPropertiesExt.java index 0122d0389..c95bc5739 100644 --- a/handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/HystrixCommandPropertiesExt.java +++ b/handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/HystrixCommandPropertiesExt.java @@ -422,6 +422,7 @@ protected HystrixCommandPropertiesExt(HystrixCommandKey key, HystrixCommandPrope } @Override + @Deprecated public HystrixProperty<Integer> metricsRollingPercentileWindow() { return metricsRollingPercentileWindowInMilliseconds; } diff --git a/handlers/handler-bizkeeper/src/test/java/org/apache/servicecomb/bizkeeper/TestBizkeeperHandler.java b/handlers/handler-bizkeeper/src/test/java/org/apache/servicecomb/bizkeeper/TestBizkeeperHandler.java index 4c0cb644a..fce992dd6 100644 --- a/handlers/handler-bizkeeper/src/test/java/org/apache/servicecomb/bizkeeper/TestBizkeeperHandler.java +++ b/handlers/handler-bizkeeper/src/test/java/org/apache/servicecomb/bizkeeper/TestBizkeeperHandler.java @@ -169,7 +169,7 @@ public Void answer(InvocationOnMock invocation) { asyncRsp.fail(InvocationType.CONSUMER, new Exception("testHandleInError")); return null; } - }).when(invocation).next(Mockito.any(AsyncResponse.class));; + }).when(invocation).next(Mockito.any(AsyncResponse.class)); bizkeeperHandler.handle(invocation, f -> { Assert.assertTrue(f.isFailed()); }); @@ -200,7 +200,7 @@ public Void answer(InvocationOnMock invocation) { asyncRsp.success(""); return null; } - }).when(invocation).next(Mockito.any(AsyncResponse.class));; + }).when(invocation).next(Mockito.any(AsyncResponse.class)); bizkeeperHandler.handle(invocation, f -> { Assert.assertTrue(f.isSuccessed()); }); diff --git a/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadBalancer.java b/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadBalancer.java index bb50ad80f..22f8b19bb 100644 --- a/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadBalancer.java +++ b/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadBalancer.java @@ -92,6 +92,7 @@ public void markServerDown(Server server) { } @Override + @Deprecated public List<Server> getServerList(boolean availableOnly) { return getAllServers(); } diff --git a/handlers/handler-loadbalance/src/test/java/org/apache/servicecomb/loadbalance/TestLoadBalancer.java b/handlers/handler-loadbalance/src/test/java/org/apache/servicecomb/loadbalance/TestLoadBalancer.java index 092bc4e4e..0259d42a0 100644 --- a/handlers/handler-loadbalance/src/test/java/org/apache/servicecomb/loadbalance/TestLoadBalancer.java +++ b/handlers/handler-loadbalance/src/test/java/org/apache/servicecomb/loadbalance/TestLoadBalancer.java @@ -51,6 +51,7 @@ public void name() { Assert.assertEquals("loadBalancerName", loadBalancer.getName()); } + @SuppressWarnings("deprecation") @Test public void testLoadBalancerFullOperationWithoutException() { List<Server> newServers = new ArrayList<>(); diff --git a/java-chassis-dependencies/pom.xml b/java-chassis-dependencies/pom.xml index 47e205824..970fc6beb 100644 --- a/java-chassis-dependencies/pom.xml +++ b/java-chassis-dependencies/pom.xml @@ -1022,6 +1022,10 @@ <configuration> <source>1.8</source> <target>1.8</target> + <compilerArguments> + <Werror /> + <Xlint:all /> + </compilerArguments> </configuration> </plugin> <plugin> diff --git a/providers/provider-pojo/src/test/java/org/apache/servicecomb/provider/pojo/TestInvoker.java b/providers/provider-pojo/src/test/java/org/apache/servicecomb/provider/pojo/TestInvoker.java index 2322e15c5..3264e6655 100644 --- a/providers/provider-pojo/src/test/java/org/apache/servicecomb/provider/pojo/TestInvoker.java +++ b/providers/provider-pojo/src/test/java/org/apache/servicecomb/provider/pojo/TestInvoker.java @@ -211,7 +211,7 @@ public void completableFutureInvoke_normal(@Mocked Invocation invocation, new MockUp<InvokerUtils>() { @Mock void reactiveInvoke(Invocation invocation, AsyncResponse asyncResp) { - asyncResp.handle(response);; + asyncResp.handle(response); } }; new Expectations() { @@ -240,7 +240,7 @@ public void completableFutureInvoke_failed(@Mocked Invocation invocation, new MockUp<InvokerUtils>() { @Mock void reactiveInvoke(Invocation invocation, AsyncResponse asyncResp) { - asyncResp.handle(response);; + asyncResp.handle(response); } }; diff --git a/swagger/swagger-generator/generator-core/src/test/java/org/apache/servicecomb/swagger/converter/model/TestModelImplConverter.java b/swagger/swagger-generator/generator-core/src/test/java/org/apache/servicecomb/swagger/converter/model/TestModelImplConverter.java index cc82bbeec..115f83b9b 100644 --- a/swagger/swagger-generator/generator-core/src/test/java/org/apache/servicecomb/swagger/converter/model/TestModelImplConverter.java +++ b/swagger/swagger-generator/generator-core/src/test/java/org/apache/servicecomb/swagger/converter/model/TestModelImplConverter.java @@ -54,7 +54,7 @@ public void getOrCreateClassName_create_packageNull() { @Test public void getOrCreateClassName_create() { - Assert.assertEquals("pkg.name", converter.getOrCreateClassName("pkg", new ModelImpl().name("name")));; + Assert.assertEquals("pkg.name", converter.getOrCreateClassName("pkg", new ModelImpl().name("name"))); } @Test ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > update pom and code, so that we can treat warnings as errors > ------------------------------------------------------------ > > Key: SCB-514 > URL: https://issues.apache.org/jira/browse/SCB-514 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis > Reporter: wujimin > Assignee: wujimin > Priority: Major > Fix For: java-chassis-1.0.0-m2 > > > supress warning tips: > 1.update maven-compiler-plugin in java-chassis-dependencies/pom.xml: > {code:java} > <configuration> > ...... > <compilerArguments> > <Werror /> > <Xlint:all /> > </compilerArguments> > </configuration>{code} > 2.deprecated class must not in import scope, if must use this class, use > qulified name in code, DO NOT import it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)