[
https://issues.apache.org/jira/browse/SCB-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16455987#comment-16455987
]
ASF GitHub Bot commented on SCB-518:
------------------------------------
wujimin commented on a change in pull request #676: [SCB-518] ServiceCenter ip
address need to config default port
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/676#discussion_r184602463
##########
File path:
service-registry/src/test/java/org/apache/servicecomb/serviceregistry/config/TestServiceRegistryConfig.java
##########
@@ -30,6 +34,7 @@
@BeforeClass
public static void initClass() {
ArchaiusUtils.resetConfig();
+ ConfigUtil.installDynamicConfig();
Review comment:
so heavy, why not just invoke ArchaiusUtils.setProperty inside test case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> ServiceCenter ip address need to config default port
> ----------------------------------------------------
>
> Key: SCB-518
> URL: https://issues.apache.org/jira/browse/SCB-518
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
> Reporter: WeiChao
> Assignee: WeiChao
> Priority: Major
>
> for http/https, the default ports are 80 and 443. if port is not configured,
> the default port needs to be used. this simplifies the configuration.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
