[
https://issues.apache.org/jira/browse/SCB-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462514#comment-16462514
]
ASF GitHub Bot commented on SCB-342:
------------------------------------
WillemJiang commented on a change in pull request #181: [SCB-342] Add TLS
support for gRPC
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/181#discussion_r185812134
##########
File path:
alpha/alpha-server/src/main/java/org/apache/servicecomb/saga/alpha/server/GrpcServerConfig.java
##########
@@ -0,0 +1,58 @@
+package org.apache.servicecomb.saga.alpha.server;
+
+import org.springframework.context.annotation.Configuration;
+import org.springframework.beans.factory.annotation.Value;
+
+@Configuration
+public class GrpcServerConfig {
+ @Value("${alpha.server.host:0.0.0.0}")
+ private String host;
+
+ @Value("${alpha.server.port:8080}")
+ private int port;
+
+ @Value("${alpha.server.ssl.enable:false}")
+ private boolean enable;
Review comment:
It could be better to use sslEnabled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [pack] secure gRPC transport
> ----------------------------
>
> Key: SCB-342
> URL: https://issues.apache.org/jira/browse/SCB-342
> Project: Apache ServiceComb
> Issue Type: New Feature
> Components: Saga
> Affects Versions: saga-0.2.0
> Reporter: Eric Lee
> Assignee: Yang Bo
> Priority: Major
>
> As a user, I want to secure the transport between alpha and omega.
> Configurations of security should be visible to developers.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
