[ 
https://issues.apache.org/jira/browse/SCB-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462645#comment-16462645
 ] 

ASF GitHub Bot commented on SCB-540:
------------------------------------

wujimin closed pull request #684: [SCB-540] delete archetypes in 
java-chassis-dependencies pom
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/684
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/java-chassis-dependencies/pom.xml 
b/java-chassis-dependencies/pom.xml
index 809eb15b2..970fc6beb 100644
--- a/java-chassis-dependencies/pom.xml
+++ b/java-chassis-dependencies/pom.xml
@@ -1009,28 +1009,6 @@
         <artifactId>metrics-prometheus</artifactId>
         <version>1.0.0-m2-SNAPSHOT</version>
       </dependency>
-
-      <dependency>
-        <groupId>org.apache.servicecomb.archetypes</groupId>
-        <artifactId>business-service-jaxrs-archetype</artifactId>
-        <version>1.0.0-m2-SNAPSHOT</version>
-      </dependency>
-      <dependency>
-        <groupId>org.apache.servicecomb.archetypes</groupId>
-        <artifactId>business-service-pojo-archetype</artifactId>
-        <version>1.0.0-m2-SNAPSHOT</version>
-      </dependency>
-      <dependency>
-        <groupId>org.apache.servicecomb.archetypes</groupId>
-        <artifactId>business-service-springmvc-archetype</artifactId>
-        <version>1.0.0-m2-SNAPSHOT</version>
-      </dependency>
-      <dependency>
-        <groupId>org.apache.servicecomb.archetypes</groupId>
-        <artifactId>business-service-spring-boot-starter-archetype</artifactId>
-        <version>1.0.0-m2-SNAPSHOT</version>
-      </dependency>
-
     </dependencies>
   </dependencyManagement>
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Delete archetypes from java-chassis-dependencies
> ------------------------------------------------
>
>                 Key: SCB-540
>                 URL: https://issues.apache.org/jira/browse/SCB-540
>             Project: Apache ServiceComb
>          Issue Type: Sub-task
>          Components: Java-Chassis
>    Affects Versions: java-chassis-1.0.0-m2
>            Reporter: yangyongzheng
>            Assignee: yangyongzheng
>            Priority: Major
>             Fix For: java-chassis-1.0.0-m2
>
>
> It's a mistake that is unnecessary for add archetypes into 
> java-chassis-dependencies, we need delete them.
> ```xml
>       <dependency>
>         <groupId>org.apache.servicecomb.archetypes</groupId>
>         <artifactId>business-service-jaxrs-archetype</artifactId>
>         <version>1.0.0-m2-SNAPSHOT</version>
>       </dependency>
>       <dependency>
>         <groupId>org.apache.servicecomb.archetypes</groupId>
>         <artifactId>business-service-pojo-archetype</artifactId>
>         <version>1.0.0-m2-SNAPSHOT</version>
>       </dependency>
>       <dependency>
>         <groupId>org.apache.servicecomb.archetypes</groupId>
>         <artifactId>business-service-springmvc-archetype</artifactId>
>         <version>1.0.0-m2-SNAPSHOT</version>
>       </dependency>
>       <dependency>
>         <groupId>org.apache.servicecomb.archetypes</groupId>
>         
> <artifactId>business-service-spring-boot-starter-archetype</artifactId>
>         <version>1.0.0-m2-SNAPSHOT</version>
>       </dependency>
> ```



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to