[
https://issues.apache.org/jira/browse/SCB-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467054#comment-16467054
]
ASF GitHub Bot commented on SCB-543:
------------------------------------
liubao68 commented on a change in pull request #692: [SCB-543]optimize registry
procedure
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/692#discussion_r186648174
##########
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/task/MicroserviceRegisterTask.java
##########
@@ -52,6 +53,11 @@ public void
onMicroserviceInstanceHeartbeatTask(MicroserviceInstanceHeartbeatTas
}
}
+ @Subscribe
Review comment:
Just set
this.taskStatus = TaskStatus.READY;
this.registered = false;
like onMicroserviceInstanceHeartbeatTask
And you do not need create new Event, just use
public void onMicroserviceRegisterTask (MicroserviceRegisterTask task) {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> optimize registry procedure
> ---------------------------
>
> Key: SCB-543
> URL: https://issues.apache.org/jira/browse/SCB-543
> Project: Apache ServiceComb
> Issue Type: Improvement
> Reporter: TaoMeng
> Assignee: TaoMeng
> Priority: Major
>
> In one case of csp upgrade scene 1: successfully registry microsevice at
> first , 2: then delete the microservice static information but instance is
> still registrying , the result is registry instance in hanging on because sc
> has no microservice static information.so in order to optimize this registry
> halt , i put registry instance procedure to registry microservice again
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
