[
https://issues.apache.org/jira/browse/SCB-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467077#comment-16467077
]
ASF GitHub Bot commented on SCB-549:
------------------------------------
codecov-io commented on issue #341: SCB-549 Do not check the instance endpoint
whether belong to other service
URL:
https://github.com/apache/incubator-servicecomb-service-center/pull/341#issuecomment-387328128
#
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/341?src=pr&el=h1)
Report
> Merging
[#341](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/341?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/ef3193e587a6e19a6abeccab522ef252517d8e7b?src=pr&el=desc)
will **increase** coverage by `0.45%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/341?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #341 +/- ##
==========================================
+ Coverage 69.5% 69.95% +0.45%
==========================================
Files 17 17
Lines 3437 3412 -25
==========================================
- Hits 2389 2387 -2
+ Misses 883 861 -22
+ Partials 165 164 -1
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/341?src=pr&el=tree)
| Coverage Δ | |
|---|---|---|
|
[server/service/instances.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/341/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VzLmdv)
| `71.13% <100%> (+2.63%)` | :arrow_up: |
|
[server/service/rule.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/341/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvcnVsZS5nbw==)
| `77.25% <0%> (+0.42%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/341?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/341?src=pr&el=footer).
Last update
[ef3193e...c22c0e8](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/341?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Do not check the instance endpoint whether belong to other service
> ------------------------------------------------------------------
>
> Key: SCB-549
> URL: https://issues.apache.org/jira/browse/SCB-549
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Service-Center
> Reporter: little-cui
> Assignee: little-cui
> Priority: Major
> Fix For: service-center-1.0.0-m2
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
