[
https://issues.apache.org/jira/browse/SCB-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476792#comment-16476792
]
ASF GitHub Bot commented on SCB-584:
------------------------------------
yangbor opened a new pull request #192: [SCB-584] Clear up testing code for
Dubbo filter tests
URL: https://github.com/apache/incubator-servicecomb-saga/pull/192
The IdGenerator is not used thus removed.
Also add omegaContext.clear() in setup to make the tests pass
in linux. But the problem still exists, the filters should use
a better way to get the omegaContext, see SCB-584 for details.
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually
before you start working on it). Trivial changes like typos do not require a
JIRA issue. Your pull request should address just this issue, without pulling
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA
issue.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> DubboConsumerFilterTest fails on linux
> --------------------------------------
>
> Key: SCB-584
> URL: https://issues.apache.org/jira/browse/SCB-584
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Saga
> Affects Versions: saga-0.2.0
> Environment: ybo@yangbo:~/repos/incubator-servicecomb-saga$ mvn -v
> Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d;
> 2017-10-18T15:58:13+08:00)
> Maven home: /opt/maven
> Java version: 1.8.0_151, vendor: Oracle Corporation
> Java home: /opt/jdk1.8.0_151/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.4.0-104-generic", arch: "amd64", family: "unix"
> Reporter: Yang Bo
> Priority: Minor
> Fix For: saga-0.2.0
>
>
> The DubboConsumerFilterTest fails with the following error:
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running SagaDubboProviderFilterTest
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.518 sec -
> in SagaDubboProviderFilterTest
> Running SagaDubboConsumerFilterTest
> Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.017 sec <<<
> FAILURE! - in SagaDubboConsumerFilterTest
> interceptTransactionIdInHeaderIfContextPresent(SagaDubboConsumerFilterTest)
> Time elapsed: 0.005 sec <<< FAILURE!
> java.lang.AssertionError:
> Expected: is "cf4a9f4a-b9e5-43f5-a7d9-837fa96ee4c0"
> but: was "3ef495de-2f2a-4afa-b991-237cd8de7e1e"
> at
> SagaDubboConsumerFilterTest.interceptTransactionIdInHeaderIfContextPresent(SagaDubboConsumerFilterTest.java:82)
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
