[
https://issues.apache.org/jira/browse/SCB-548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478652#comment-16478652
]
ASF GitHub Bot commented on SCB-548:
------------------------------------
zhengyangyong commented on issue #693: [SCB-548] support gracefully shutdown
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#issuecomment-389770794
Failed by apollo it , [[1;31mERROR[m] Failed to execute goal
[32mio.fabric8:docker-maven-plugin:0.20.0:start[m [1m(start)[m on project
[36mdynamic-config-tests[m: [1;31mExecution start of goal
io.fabric8:docker-maven-plugin:0.20.0:start failed: Start-Job failed with
unexpected exception: [nobodyiam/apollo-quick-start]
"apollo.servicecomb.apache.org": Timeout after 120162 ms while waiting on log
out 'Portal started' and on tcp port '[/172.17.0.3:8080, /172.17.0.3:8070]'[m
-> [1m[Help 1][m Reopen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Support Gracefully Shutdown
> ---------------------------
>
> Key: SCB-548
> URL: https://issues.apache.org/jira/browse/SCB-548
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
> Affects Versions: java-chassis-1.0.0-m2
> Reporter: yangyongzheng
> Assignee: yangyongzheng
> Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> We did not implement gracefully shutdown yet:
> ```java
> // 当程序退出时，进行相关清理，注意：kill -9 {pid}下无效
> // 1. 去注册实例信息
> // TODO 服务优雅退出
> if (applicationContext instanceof AbstractApplicationContext) {
> ((AbstractApplicationContext)
> applicationContext).registerShutdownHook();
> }
> ```
>
> And had got an issue :
> https://github.com/apache/incubator-servicecomb-java-chassis/issues/685 from
> user.
> So it's time we must do it and remove this TODO
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
