[ 
https://issues.apache.org/jira/browse/SCB-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480252#comment-16480252
 ] 

ASF GitHub Bot commented on SCB-591:
------------------------------------

liubao68 commented on a change in pull request #713:  [SCB-591] configcenter 
need to do encode
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/713#discussion_r189177929
 
 

 ##########
 File path: 
dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterClient.java
 ##########
 @@ -329,8 +329,14 @@ private void sendHeartbeat(WebSocket ws) {
 
     public void refreshConfig(String configcenter, boolean wait) {
       CountDownLatch latch = new CountDownLatch(1);
+      String encodeServiceName = "";
+      try {
+        encodeServiceName = 
URLEncoder.encode(StringUtils.deleteWhitespace(serviceName), "UTF-8");
+      } catch (UnsupportedEncodingException e) {
+        LOGGER.error("encode error: {}",e.getMessage());
 
 Review comment:
   we can encoding serviceName in instance initialization if possible.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> configcenter need to do encode
> ------------------------------
>
>                 Key: SCB-591
>                 URL: https://issues.apache.org/jira/browse/SCB-591
>             Project: Apache ServiceComb
>          Issue Type: Bug
>          Components: Java-Chassis
>            Reporter: WeiChao
>            Assignee: WeiChao
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to