[ 
https://issues.apache.org/jira/browse/SCB-607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490327#comment-16490327
 ] 

ASF GitHub Bot commented on SCB-607:
------------------------------------

liubao68 commented on a change in pull request #727: [SCB-607] Accesslog 
support invocation context item
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/727#discussion_r190806272
 
 

 ##########
 File path: 
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/AbstractRestInvocation.java
 ##########
 @@ -249,4 +265,21 @@ protected void onExecuteHttpServerFiltersFinish(Response 
response, Throwable e)
       invocation.onFinish(response);
     }
   }
+
+  public void setAfterCreateInvocationHandler(
 
 Review comment:
   Maybe create a new protected method is better.
   protected void afterCreateInvocation()
   protected void beforeCreateInvocation()
   protected void createInvocation()
   
    And we can implement it in RestProducerInvocation, e.g
   RestProducerInvocation invo = new RestProducerInvocation.java(RoutingContext 
context)
   ..

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support printing invocation context in access log
> -------------------------------------------------
>
>                 Key: SCB-607
>                 URL: https://issues.apache.org/jira/browse/SCB-607
>             Project: Apache ServiceComb
>          Issue Type: New Feature
>          Components: Java-Chassis
>            Reporter: YaoHaishi
>            Assignee: YaoHaishi
>            Priority: Major
>             Fix For: java-chassis-1.0.0-m2
>
>
> Add a new access log item to print specific invocation context content.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to