[
https://issues.apache.org/jira/browse/SCB-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16491328#comment-16491328
]
ASF GitHub Bot commented on SCB-245:
------------------------------------
WillemJiang commented on a change in pull request #185: [SCB-245]: add
acceptance test for dubbo demo
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/185#discussion_r191021454
##########
File path:
omega/omega-transport/omega-transport-dubbo/src/test/java/SagaDubboProviderFilterTest.java
##########
@@ -45,7 +45,6 @@
@Before
public void setUp() {
omegaContext.clear();
- ApplicationContext applicationContext = mock(ApplicationContext.class);
Review comment:
@wuzunqian Could you take a look at the
https://issues.apache.org/jira/browse/SCB-584? As you use a static method to
pass the mocked ApplicationContext, it will cause some trouble if there are two
tests running in the same JVM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [pack] support to intercept dubbo's requests
> --------------------------------------------
>
> Key: SCB-245
> URL: https://issues.apache.org/jira/browse/SCB-245
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Saga
> Affects Versions: saga-0.2.0
> Reporter: Eric Lee
> Assignee: wuzunqian
> Priority: Minor
> Fix For: saga-0.2.0
>
>
> as a sdk, I want to be able to intercept the incoming and outgoing requests
> of apps developed by dubbo and inject the transaction ids in its header.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
