[
https://issues.apache.org/jira/browse/SCB-562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492360#comment-16492360
]
ASF GitHub Bot commented on SCB-562:
------------------------------------
zhengyangyong commented on a change in pull request #729: [SCB-562] fix NPE
when had empty interface (not have any method)
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/729#discussion_r191133406
##########
File path:
core/src/main/java/org/apache/servicecomb/core/definition/SchemaMeta.java
##########
@@ -83,40 +83,42 @@ public String getPackageName() {
}
private void initOperations() {
- for (Entry<String, Path> entry : swagger.getPaths().entrySet()) {
- String strPath = entry.getKey();
- Path path = entry.getValue();
- for (Entry<HttpMethod, Operation> operationEntry :
path.getOperationMap().entrySet()) {
- Operation operation = operationEntry.getValue();
- if (operation.getOperationId() == null) {
- throw ExceptionUtils.operationIdInvalid(getSchemaId(), strPath);
+ if (swagger.getPaths() != null) {
Review comment:
I think no necessary, user want fill this empty interface later, so it's not
a **wrong scenario**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Java Chassis will throw NPE when producer impl do not contain any method
> ------------------------------------------------------------------------
>
> Key: SCB-562
> URL: https://issues.apache.org/jira/browse/SCB-562
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
> Affects Versions: java-chassis-1.0.0-m1
> Reporter: yangyongzheng
> Assignee: yangyongzheng
> Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> If a producer impl do not contain any method like :
> ```java
> @RestSchema(schemaId = "hello")
> @Path("/")
> public class HelloImpl {
> }
> ```
> Then an NPE will throw when startup:
> 2018-05-09 08:50:04,333 [ERROR] cse init failed,
> Exception: java.lang.NullPointerException; null
> java.lang.NullPointerException
> at
> org.apache.servicecomb.swagger.generator.core.utils.ClassUtils.createInterface(ClassUtils.java:212)
> at
> org.apache.servicecomb.swagger.generator.core.utils.ClassUtils.getOrCreateInterface(ClassUtils.java:203)
> at
> org.apache.servicecomb.swagger.generator.core.utils.ClassUtils.getOrCreateInterface(ClassUtils.java:182)
> at
> org.apache.servicecomb.core.definition.schema.AbstractSchemaFactory.generateSwagger(AbstractSchemaFactory.java:112)
> at
> org.apache.servicecomb.core.definition.schema.ProducerSchemaFactory.createSchema(ProducerSchemaFactory.java:110)
> at
> org.apache.servicecomb.core.definition.schema.ProducerSchemaFactory.createSchema(ProducerSchemaFactory.java:47)
> at
> org.apache.servicecomb.core.definition.schema.AbstractSchemaFactory.getOrCreateSchema(AbstractSchemaFactory.java:65)
> at
> org.apache.servicecomb.core.definition.schema.ProducerSchemaFactory.getOrCreateProducerSchema(ProducerSchemaFactory.java:80)
> at
> org.apache.servicecomb.provider.rest.common.RestProducerProvider.init(RestProducerProvider.java:48)
> at
> org.apache.servicecomb.core.provider.producer.ProducerProviderManager.init(ProducerProviderManager.java:45)
> at
> org.apache.servicecomb.core.CseApplicationListener.onApplicationEvent(CseApplicationListener.java:118)
> at
> org.springframework.context.event.SimpleApplicationEventMulticaster.invokeListener(SimpleApplicationEventMulticaster.java:166)
> at
> org.springframework.context.event.SimpleApplicationEventMulticaster.multicastEvent(SimpleApplicationEventMulticaster.java:138)
> at
> org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:383)
> at
> org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:337)
> at
> org.springframework.context.support.AbstractApplicationContext.finishRefresh(AbstractApplicationContext.java:882)
> at
> org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:545)
> at
> org.springframework.context.support.ClassPathXmlApplicationContext.<init>(ClassPathXmlApplicationContext.java:139)
> at
> org.springframework.context.support.ClassPathXmlApplicationContext.<init>(ClassPathXmlApplicationContext.java:93)
> at
> org.apache.servicecomb.foundation.common.utils.BeanUtils.init(BeanUtils.java:37)
> at
> org.apache.servicecomb.foundation.common.utils.BeanUtils.init(BeanUtils.java:33)
> at io.demo.Application.main(Application.java:40)
>
> org.apache.servicecomb.core.CseApplicationListener.onApplicationEvent(CseApplicationListener.java:145)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
