[
https://issues.apache.org/jira/browse/SCB-601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496329#comment-16496329
]
ASF GitHub Bot commented on SCB-601:
------------------------------------
WillemJiang commented on a change in pull request #743: [SCB-601] when
java.lang.Error: not support def type: class io.swagger.models.ComposedMode we
don't know which swagger
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/743#discussion_r192047265
##########
File path:
core/src/main/java/org/apache/servicecomb/core/definition/SchemaMeta.java
##########
@@ -57,21 +57,26 @@
private SwaggerToClassGenerator swaggerToClassGenerator;
public SchemaMeta(Swagger swagger, MicroserviceMeta microserviceMeta, String
schemaId) {
- this.packageName = SchemaUtils.generatePackageName(microserviceMeta,
schemaId);
+ try {
+ this.packageName = SchemaUtils.generatePackageName(microserviceMeta,
schemaId);
- this.swagger = swagger;
- this.name = schemaId;
+ this.swagger = swagger;
+ this.name = schemaId;
- this.microserviceMeta = microserviceMeta;
- this.microserviceQualifiedName = microserviceMeta.getName() + "." +
schemaId;
+ this.microserviceMeta = microserviceMeta;
+ this.microserviceQualifiedName = microserviceMeta.getName() + "." +
schemaId;
- swaggerToClassGenerator = new
SwaggerToClassGenerator(microserviceMeta.getClassLoader(), swagger,
packageName);
- swaggerIntf = swaggerToClassGenerator.convert();
+ swaggerToClassGenerator = new
SwaggerToClassGenerator(microserviceMeta.getClassLoader(), swagger,
packageName);
+ swaggerIntf = swaggerToClassGenerator.convert();
- createOperationMgr("schemaMeta " + schemaId + " operation mgr");
- operationMgr.setRegisterErrorFmt("Operation name repeat, schema=%s,
operation=%s");
+ createOperationMgr("schemaMeta " + schemaId + " operation mgr");
+ operationMgr.setRegisterErrorFmt("Operation name repeat, schema=%s,
operation=%s");
- initOperations();
+ initOperations();
+ } catch (Throwable e) {
Review comment:
It's better to log the error with the exception, so we can get the stack
trace of it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ServiceComb integrated to spring boot or tomcat will print too many logs
> ------------------------------------------------------------------------
>
> Key: SCB-601
> URL: https://issues.apache.org/jira/browse/SCB-601
> Project: Apache ServiceComb
> Issue Type: Task
> Reporter: liubao
> Assignee: liubao
> Priority: Minor
> Fix For: java-chassis-1.0.0-m2
>
>
> 2018-05-23 19:40:31.495 INFO 4812 --- [ntloop-thread-0]
> o.a.s.t.r.c.http.RestClientInvocation : http connection connected,
> local:192.168.0.204:59718, remote:192.168.0.204:7211.
> 2018-05-23 19:40:31.500 INFO 4812 --- [ntloop-thread-0]
> o.a.s.t.r.c.http.RestClientInvocation : http connection closed,
> local:192.168.0.204:59705, remote:192.168.0.204:7211.
> 2
>
> In tomcat or some other HTTP short connections scenario, this logs comes too
> frequently/
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
