[ 
https://issues.apache.org/jira/browse/SCB-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508172#comment-16508172
 ] 

ASF GitHub Bot commented on SCB-644:
------------------------------------

codecov-io commented on issue #370:  SCB-644 Add resource limitations 
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/370#issuecomment-394683645
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/370?src=pr&el=h1)
 Report
   > Merging 
[#370](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/370?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/e729a5ee0faf8bd5db2a1fd2539fc7b62bb66b54?src=pr&el=desc)
 will **decrease** coverage by `1.52%`.
   > The diff coverage is `60.59%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/370/graphs/tree.svg?token=GAaF7zrg8R&width=650&height=150&src=pr)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/370?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #370      +/-   ##
   ==========================================
   - Coverage   71.46%   69.94%   -1.53%     
   ==========================================
     Files          25       25              
     Lines        3690     3746      +56     
   ==========================================
   - Hits         2637     2620      -17     
   - Misses        884      938      +54     
   - Partials      169      188      +19
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/370?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[server/service/util/instance\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/370/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv)
 | `50.45% <0%> (+1.38%)` | :arrow_up: |
   | 
[server/service/util/microservice\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/370/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9taWNyb3NlcnZpY2VfdXRpbC5nbw==)
 | `75.44% <0%> (ø)` | :arrow_up: |
   | 
[server/service/util/versionrule.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/370/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC92ZXJzaW9ucnVsZS5nbw==)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[server/service/rule\_validator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/370/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvcnVsZV92YWxpZGF0b3IuZ28=)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[server/service/schema\_validator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/370/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvc2NoZW1hX3ZhbGlkYXRvci5nbw==)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[server/service/instance\_validator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/370/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VfdmFsaWRhdG9yLmdv)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[server/service/dependency\_validator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/370/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvZGVwZW5kZW5jeV92YWxpZGF0b3IuZ28=)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[server/service/util/dependency.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/370/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5Lmdv)
 | `54% <100%> (-2.18%)` | :arrow_down: |
   | 
[server/service/microservice\_validator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/370/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvbWljcm9zZXJ2aWNlX3ZhbGlkYXRvci5nbw==)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[server/service/validate.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/370/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdmFsaWRhdGUuZ28=)
 | `84.48% <100%> (+2.48%)` | :arrow_up: |
   | ... and [11 
more](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/370/diff?src=pr&el=tree-more)
 | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/370?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/370?src=pr&el=footer).
 Last update 
[e729a5e...98cc48a](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/370?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add resource limitations
> ------------------------
>
>                 Key: SCB-644
>                 URL: https://issues.apache.org/jira/browse/SCB-644
>             Project: Apache ServiceComb
>          Issue Type: Improvement
>          Components: Service-Center
>            Reporter: little-cui
>            Assignee: little-cui
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to