[
https://issues.apache.org/jira/browse/SCB-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518139#comment-16518139
]
ASF GitHub Bot commented on SCB-244:
------------------------------------
WillemJiang commented on a change in pull request #210: [SCB-244] enable
servicecomb and add demo
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/210#discussion_r196776346
##########
File path:
omega/omega-transport/omega-transport-servicecomb/src/main/java/org/apache/servicecomb/saga/omega/transport/servicecomb/SagaProviderHandler.java
##########
@@ -22,27 +22,35 @@
import java.lang.invoke.MethodHandles;
+import org.apache.servicecomb.core.Handler;
+import org.apache.servicecomb.core.Invocation;
+import org.apache.servicecomb.foundation.common.utils.BeanUtils;
import org.apache.servicecomb.saga.omega.context.OmegaContext;
+import org.apache.servicecomb.swagger.invocation.AsyncResponse;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import org.springframework.beans.factory.annotation.Autowired;
-import org.apache.servicecomb.core.Handler;
-import org.apache.servicecomb.core.Invocation;
-import org.apache.servicecomb.swagger.invocation.AsyncResponse;
+import com.google.common.annotations.VisibleForTesting;
public class SagaProviderHandler implements Handler {
private static final Logger LOG =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
- private final OmegaContext omegaContext;
- public SagaProviderHandler(@Autowired(required=false) OmegaContext
omegaContext) {
- this.omegaContext = omegaContext;
- if (omegaContext == null) {
- LOG.info("The OmegaContext is not injected, The SagaProviderHander is
disabled.");
+ private OmegaContext omegaContext;
Review comment:
It's better to use the final object to avoid the change from outside.
We could add a new construction method which set the omegaContext to be null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [pack] add demo to use pack with java chassis
> ---------------------------------------------
>
> Key: SCB-244
> URL: https://issues.apache.org/jira/browse/SCB-244
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Saga
> Affects Versions: saga-0.2.0
> Reporter: Eric Lee
> Assignee: yangyongzheng
> Priority: Minor
> Fix For: saga-0.3.0
>
>
> as a dev, I want to know how I can use pack with Java Chassis.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
