[
https://issues.apache.org/jira/browse/SCB-684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520072#comment-16520072
]
ASF GitHub Bot commented on SCB-684:
------------------------------------
wujimin commented on a change in pull request #773: [SCB-684]Following swagger
conventions. Adding and change some test cases.
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/773#discussion_r197361520
##########
File path:
demo/demo-springmvc/springmvc-server/src/main/resources/META-INF/spring/springmvc.server.bean.xml
##########
@@ -0,0 +1,25 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<beans xmlns="http://www.springframework.org/schema/beans";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://www.springframework.org/schema/beans
classpath:org/springframework/beans/factory/xml/spring-beans-3.0.xsd">
+
+ <bean id="ProducerSchemaFactoryHolder"
Review comment:
just write annotation in class is enough?
```
@Component
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Following swagger conventions
> -----------------------------
>
> Key: SCB-684
> URL: https://issues.apache.org/jira/browse/SCB-684
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
> Reporter: liubao
> Assignee: liubao
> Priority: Major
>
> Check with swagger validator, some warnings and errors are given:
>
>
> Errors Hide Semantic error at paths./add.post Operations with Parameters of
> "in: formData" must include "application/x-www-form-urlencoded" or
> "multipart/form-data" in their "consumes" property Jump to line 13 Semantic
> error at paths./add.post Operations with Parameters of "in: formData" must
> include "application/x-www-form-urlencoded" or "multipart/form-data" in their
> "consumes" property Jump to line 13 Schema error at
> paths['/reduce'].get.parameters[0] should NOT have additional properties
> additionalProperty: type, format, name, in, required Jump to line 36 Schema
> error at paths['/reduce'].get.parameters[0].required should be equal to one
> of the allowed values allowedValues: true Jump to line 36 Schema error at
> paths['/reduce'].get.paramete
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
