[
https://issues.apache.org/jira/browse/SCB-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16532294#comment-16532294
]
ASF GitHub Bot commented on SCB-713:
------------------------------------
liubao68 commented on a change in pull request #789: [SCB-713] @DefaulValue
should be set only when input param is null
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/789#discussion_r200017012
##########
File path:
demo/demo-springmvc/springmvc-client/src/main/java/org/apache/servicecomb/demo/springmvc/client/SpringmvcClient.java
##########
@@ -220,53 +225,83 @@ private static void testConfigurationDuplicate() {
"newer");
}
- private static void testDefaultValues(RestTemplate template, String
microserviceName) {
- String prefix = "cse://" + microserviceName;
- TestMgr.check("hi test your age is : 20",
- template.getForObject(prefix + "/annotations/sayhi",
- String.class));
-
- TestMgr.check("20",
- template.getForObject(prefix + "/annotations/add",
- String.class));
-
- TestMgr.check("hei test",
- template.getForObject(prefix + "/annotations/sayhei",
- String.class));
- }
-
- private static void testRequiredBody(RestTemplate template, String
microserviceName) {
Review comment:
Why this test case if removed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> @DefaulValue should be set only when input param is null
> --------------------------------------------------------
>
> Key: SCB-713
> URL: https://issues.apache.org/jira/browse/SCB-713
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
> Reporter: sukesh
> Assignee: sukesh
> Priority: Major
>
> 1.Default value should not set when input is empty(a=)
> 2.Default value is not mapped correctly when order is changed
> 3.Invalid default value is set even not configured
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
