[
https://issues.apache.org/jira/browse/SCB-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535770#comment-16535770
] ASF GitHub Bot commented on SCB-680: ------------------------------------ codecov-io edited a comment on issue #387: SCB-680 Optimize find instance api URL: https://github.com/apache/incubator-servicecomb-service-center/pull/387#issuecomment-403055353 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/387?src=pr&el=h1) Report > Merging [#387](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/387?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/3d9e55460f658abeefd3290de482eff2ae238cd7?src=pr&el=desc) will **increase** coverage by `1.12%`. > The diff coverage is `66.1%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/387?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #387 +/- ## ========================================== + Coverage 70.37% 71.49% +1.12% ========================================== Files 26 39 +13 Lines 3811 4126 +315 ========================================== + Hits 2682 2950 +268 - Misses 943 1007 +64 + Partials 186 169 -17 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/387?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [server/service/util/dependency.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/387/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5Lmdv) | `37.2% <ø> (-16.47%)` | :arrow_down: | | [server/service/watch.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/387/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvd2F0Y2guZ28=) | `70.96% <0%> (ø)` | :arrow_up: | | [server/service/util/tag\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/387/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC90YWdfdXRpbC5nbw==) | `69.23% <0%> (+4.71%)` | :arrow_up: | | [server/service/microservice.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/387/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvbWljcm9zZXJ2aWNlLmdv) | `71.19% <0%> (ø)` | :arrow_up: | | [server/service/util/versionrule.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/387/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC92ZXJzaW9ucnVsZS5nbw==) | `100% <100%> (ø)` | :arrow_up: | | [server/service/notification/group.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/387/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL2dyb3VwLmdv) | `100% <100%> (ø)` | | | [server/service/notification/subscriber.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/387/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3N1YnNjcmliZXIuZ28=) | `100% <100%> (ø)` | | | [server/service/util/domain\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/387/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kb21haW5fdXRpbC5nbw==) | `61.19% <100%> (-10.45%)` | :arrow_down: | | [server/service/notification/notice.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/387/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL25vdGljZS5nbw==) | `100% <100%> (ø)` | | | [server/service/schema.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/387/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvc2NoZW1hLmdv) | `75.75% <100%> (ø)` | :arrow_up: | | ... and [35 more](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/387/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/387?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/387?src=pr&el=footer). Last update [3d9e554...f7983a2](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/387?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] > Optimize find instance api > -------------------------- > > Key: SCB-680 > URL: https://issues.apache.org/jira/browse/SCB-680 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center > Reporter: little-cui > Assignee: little-cui > Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
